Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two fixes and one feature #52

Merged
merged 4 commits into from
Apr 18, 2018
Merged

Two fixes and one feature #52

merged 4 commits into from
Apr 18, 2018

Conversation

marcorieser
Copy link
Contributor

@marcorieser marcorieser commented Apr 11, 2018 •
edited
Loading

  • Added .hidden-xlg class (Fix for .hidden-xlg #51 )
  • Put properties with star hack inside a legacy condition

@marcorieser marcorieser mentioned this pull request Apr 11, 2018
Closed
@marcorieser marcorieser changed the title Fix for Issue #51 Two fixes Apr 11, 2018
@leejordan
Copy link
Owner

Thanks. Looks good. I'm a bit short of time at the moment but I'll sort this in the near future. 👍

@marcorieser marcorieser changed the title Two fixes Two fixes and one feature Apr 12, 2018
@marcorieser
Copy link
Contributor Author

Fix for request #49

@marcorieser
Copy link
Contributor Author

Sorry for not making a feature branch for each fix.

@leejordan
Copy link
Owner

Hey man no problem at all I'm just really grateful for your assistance. I'll take a look over it all when I get a chance.

Thanks again.

leejordan
leejordan approved these changes Apr 17, 2018
View reviewed changes
Copy link
Owner

@leejordan leejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look perfect to me. Just gonna add some bits to the docs to cover the additions and in so doing, give everything a test.

Thanks

@marcorieser
Copy link
Contributor Author

👍🏻

@leejordan leejordan merged commit bb45e67 into leejordan:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leejordan leejordan leejordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcorieser @leejordan