Write metadata separately #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
covr: 100% test: 7 pass, 0 fail
still needs tests but tests are broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #17.
I originally started just excising the metadata writing part but soon enough realised that you really want a slightly different code path -- diverging before the csv component is written but after the metadata is written. I've added a
metadata_onlyflag towrite_csvyto achieve this.I still split out
write_metadatabecause it's more modular and can be tested independently, and can be used to write a comparable file from a list generated independent of this package.Added 14 tests, 100% coverage of
write_metadata.Check was like that when I found it... it's not more broken.
I recommend squash on merge.