Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies. #11

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Update dependencies. #11

merged 1 commit into from
Mar 26, 2022

Conversation

sunoru
Copy link
Contributor

@sunoru sunoru commented Mar 24, 2022

Hi,

I was going to use this package in my existing project but found it was restricting the versions of ImageMagick.jl and Images.jl which caused conflicts.

I tested it with new versions of those packages and thought this update would be nice.

@leferrad
Copy link
Owner

Hi @sunoru, thanks for your contribution! I've just merged #12 and #13 so we can retest this PR in order to ensure it does work with the last changes in CI and tests.

@leferrad leferrad self-requested a review March 26, 2022 18:07
leferrad
leferrad approved these changes Mar 26, 2022
View reviewed changes
Copy link
Owner

@leferrad leferrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@leferrad leferrad merged commit 067b8ff into leferrad:master Mar 26, 2022
@leferrad leferrad mentioned this pull request Mar 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leferrad leferrad leferrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunoru @leferrad