-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extra args to tesseract #16
Conversation
This allows one to pass additional command-line arguments to tesseract. This makes it possible to exploit more of its functionality.
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 96.07% 96.00% -0.08%
==========================================
Files 1 1
Lines 51 50 -1
==========================================
- Hits 49 48 -1
Misses 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks for your contribution @timholy! This is definitely a needed improvement to allow better usability 🙌 Give me a couple of days to check the changes better through a code review, also to understand why CI is failing for the nightly version. Once everything is OK we can merge and release a new version of the package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a couple of suggestions / questions, then we are ok to approve 👌
Co-authored-by: Leandro Ferrado <leferrad@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM! CI is not working but for compatibility with the nightly version, which is out of the scope of this PR. So we can merge this, and then I proceed to prepare the release. Thanks again @timholy !
You surely noticed this, but the failure is ultimately due to SimpleMocking's use of Cassette. Cassette dives deep into Julia internals and is difficult to keep in working order, since the internal representation of code is deliberately not covered by the compatibility guarantee. To the extent that the failure bothers you, you could omit the mocking tests on Julia nightly? |
This allows one to pass additional command-line arguments to tesseract.
This makes it possible to exploit more of its functionality.
For example, in applications where layout is meaningful (e.g., screenshots),
retrieving the full TSV can be very useful.