Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAIA-2819] Fix undefined child in RatingDecorator if elements is empty #77

Merged

Conversation

rschluesselbauer
Copy link
Contributor

If the elements array is empty, child was undefined and child.type was called leading to an error.

Now child cannot be undefined anymore.

@rschluesselbauer rschluesselbauer changed the title [INFRASTRUCTURE] Fix undefined child in RatingDecorator if elements is empty [GAIA-2819] Fix undefined child in RatingDecorator if elements is empty Feb 17, 2021
@aemaem
Copy link
Contributor

aemaem commented Feb 17, 2021

@rschluesselbauer bitte ein patch release machen

LoLei
LoLei previously approved these changes Feb 17, 2021
src/lib/renderer/__tests__/RatingDecorator.test.ts Outdated Show resolved Hide resolved
@rschluesselbauer rschluesselbauer merged commit 08473fb into master Feb 17, 2021
@rschluesselbauer rschluesselbauer deleted the infrastructure/undefined-access-in-rating-decorator branch February 17, 2021 09:13
@rschluesselbauer
Copy link
Contributor Author

@aemaem ist released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants