chore: remove redundant CreateRun magic string #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do, thank you! |
leg100
pushed a commit
that referenced
this pull request
Aug 2, 2023
🤖 I have created a release *beep* *boop* --- ## [0.1.6](v0.1.5...v0.1.6) (2023-08-02) ### Features * record who created a run ([#556](#556)) ([57bb9b6](57bb9b6)) * **ui:** clicking on workspace widget tag filters by that tag ([a7ce9a8](a7ce9a8)) * **ui:** provide more vcs metadata for runs ([#552](#552)) ([18217ce](18217ce)) ### Miscellaneous * add organization UI tests ([1c7e3db](1c7e3db)) * remove redundant CreateRun magic string ([#555](#555)) ([a2df6d5](a2df6d5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fsaintjacques A heads up - I recall removing the magic string behaviour from your software, so I'm pretty sure this is now safe to remove from OTF.
(If you recall, when creating a run, we wanted the run to automatically fetch the config from the git repo, so we introduced a magic string to invoke this behaviour. But then I realised you could simply leave out the configuration version ID from CreateRun and that invokes the same behaviour).