Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gitlab support #665

Merged
merged 4 commits into from
Dec 12, 2023
Merged

fix: gitlab support #665

merged 4 commits into from
Dec 12, 2023

Conversation

leg100
Copy link
Owner

@leg100 leg100 commented Dec 9, 2023

This PR builds upon #654 to fix further Gitlab issues, and to bring it generally into line with the Github support.

Fixes #651

@leg100 leg100 merged commit eaf9b15 into master Dec 12, 2023
5 checks passed
@leg100
Copy link
Owner Author

leg100 commented Dec 12, 2023

@robbert229 Check out these changes.

There is some refactoring around the event handling you'll need to incorporate into your BBS PR. It's important to use the Validate() function at the end, which confirms you've correctly constructed the OTF event. The handler unit tests are pretty thorough, covering a fair number of the different payloads that can be received. I found it time consuming to do, manually triggering the necessary events from Gitlab, opening/closing merge requests, etc, to generate the payloads.

I would also treat the Gitlab client unit tests as a reference for your unit tests. I think you'll agree they're far more succinct than the big "test server" stub they were using (and the Github client unit tests still uses but I intend to migrate that over shortly to something similar).

leg100 pushed a commit that referenced this pull request Dec 12, 2023
🤖 I have created a release *beep* *boop*
---


## [0.2.3](v0.2.2...v0.2.3)
(2023-12-12)


### Bug Fixes

* gitlab support ([#665](#665))
([eaf9b15](eaf9b15)),
closes [#651](#651)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@leg100 leg100 deleted the fix-gitlab-support branch December 16, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitlab repo download fails
1 participant