Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#714] mock time.time func #728

Merged
merged 1 commit into from
Jan 15, 2019
Merged

[#714] mock time.time func #728

merged 1 commit into from
Jan 15, 2019

Conversation

mcdoker18
Copy link
Contributor

We need mock time function because it can return different timestamps.

This fixes the comment: #714 (comment)

@mcdoker18
[#714] mock time.time func
68e3d2f 
We need mock time function because it can return different timestamps.

This fixes the comment: #714 (comment)
@mcdoker18 mcdoker18 self-assigned this Jan 12, 2019
@mcdoker18 mcdoker18 requested a review from a team as a code owner January 12, 2019 13:34
@mcdoker18
Copy link
Contributor Author

bot, test all

@legion-bot
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@legion-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@legion-bot
Copy link
Collaborator

Build status: SUCCESS

kirillmakhonin
kirillmakhonin approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@kirillmakhonin kirillmakhonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dsuslov
dsuslov approved these changes Jan 15, 2019
View reviewed changes
Copy link

@dsuslov dsuslov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dsuslov dsuslov merged commit 02ba88a into develop Jan 15, 2019
@dsuslov dsuslov deleted the feat/714-mock-time branch January 15, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@botsman botsman botsman approved these changes

@kirillmakhonin kirillmakhonin kirillmakhonin approved these changes

@dsuslov dsuslov dsuslov approved these changes

Assignees

@mcdoker18 mcdoker18

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcdoker18 @legion-bot @dsuslov @kirillmakhonin @botsman