Add hcesar.map #118
Add hcesar.map #118
Conversation
|
Please explain what kind of hcesar keyboard layout is this? Also kbd uses DCO to format patches. Please add https://github.com/legionus/kbd/blob/master/docs/process/howto-contribute.md#sending-patches |
|
Hcesar is a non-qwerty keyboard optimized for Portuguese, much like the Turkish F for Turkish. It's available here: https://help.keyman.com/keyboard/hcesar/1.2/hcesar |
data/keymaps/i386/hcesar/hcesar.map
Outdated
| keycode 26 = plus asterisk dead_diaeresis | ||
| control keycode 26 = Escape | ||
| alt keycode 26 = Meta_bracketleft | ||
| keycode 27 = dead_acute dead_grave apostrophe grave |
There was a problem hiding this comment.
Why is apostrophe on this key? Can we document this decision?
There was a problem hiding this comment.
its the same as in pt-latin1.map.
maybe it should be acute.
data/keymaps/i386/hcesar/hcesar.map
Outdated
| charset "iso-8859-1" | ||
| keymaps 0-2,4,6,8,12 | ||
| alt_is_meta | ||
| include "qwerty-layout" |
There was a problem hiding this comment.
Do you need to include qwerty-layout if it's a non-qwerty layout?
data/keymaps/i386/hcesar/hcesar.map
Outdated
| control keycode 43 = Control_backslash | ||
| alt keycode 43 = Meta_backslash | ||
| keycode 44 = y | ||
| keycode 45 = +ccedilla Ccedilla |
There was a problem hiding this comment.
Perhaps it should be +ccedilla +Ccedilla?
There was a problem hiding this comment.
its +ccedilla Ccedilla
on pt-latin1.map and pt-latin9.map.
| control keycode 41 = nul | ||
| alt keycode 41 = Meta_grave | ||
| keycode 42 = Shift | ||
| keycode 43 = dead_tilde dead_circumflex asciitilde asciicircum |
There was a problem hiding this comment.
I don't see ~ on https://en.wikipedia.org/wiki/HCESAR. Why was it decided to put it on this key?
There was a problem hiding this comment.
its there, same as pt-latin1.map.
data/keymaps/i386/hcesar/hcesar.map
Outdated
| keycode 37 = l | ||
| keycode 38 = m | ||
| keycode 39 = x | ||
| alt keycode 39 = Meta_semicolon |
There was a problem hiding this comment.
Why 39 is x, but alt 39 is M-;? I don't see a key with M-x.
|
Please add this line into the commit message. Other than that LGTM. |
ghost
|
@mareuo You need to squash commits. |
This adds hcesar layout, for portuguese speaking countries. fixes Signed-off-by: Mario Oliveira <mauruon@proton.me>
Add hcesar layout, for portuguese speaking countries. This keymap is more like a tribute to history. Link: #118 Signed-off-by: Alexey Gladkov <legion@kernel.org>
|
Applied with minor changes. |
This adds hcesar layout, for portuguese speaking countries.