Switch frontend globals to use Vite defines #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup I did before realizing I could just do window.gbans.site_name in leighmacdonald#503 (comment)...
|
Its my first time using vite, so i'm sure i've done a number of things sub optimally :). Thanks for the changes, looks good. I fixed up the minor conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this refactor for #503 before realizing I could just use
window.gbans.site_nameFigured I'd offer this to you anyways as using Vite defines is a bit more idiomatic and compiles a little more efficiently (it saves ~200 bytes off of index.html and ~1kb off of index.js)
I tested by poking around the site and also running
./node_modules/.bin/tsc --noEmitand noticing no new type errors. release.sh also still works.This PR temporarily is stacked on top of the commit from #503... sorry, I'm not sure about modern github etiquette for stacked commits, I'll sort it out as that PR lands.