Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing parameter name to error message. #20

Merged
merged 1 commit into from
Jan 12, 2019
Merged

Add missing parameter name to error message. #20

merged 1 commit into from
Jan 12, 2019

Conversation

brentsnook
Copy link
Contributor

@brentsnook brentsnook commented Nov 20, 2018 •
edited by leighmcculloch
Loading

Fixes #19

leighmcculloch
leighmcculloch approved these changes Nov 20, 2018
View reviewed changes
Copy link
Owner

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing this!

@leighmcculloch leighmcculloch mentioned this pull request Nov 20, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 97.808% when pulling 867c447 on brentsnook:master into 707b966 on leighmcculloch:master.

7 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 97.808% when pulling 867c447 on brentsnook:master into 707b966 on leighmcculloch:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 97.808% when pulling 867c447 on brentsnook:master into 707b966 on leighmcculloch:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 97.808% when pulling 867c447 on brentsnook:master into 707b966 on leighmcculloch:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 97.808% when pulling 867c447 on brentsnook:master into 707b966 on leighmcculloch:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 97.808% when pulling 867c447 on brentsnook:master into 707b966 on leighmcculloch:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 97.808% when pulling 867c447 on brentsnook:master into 707b966 on leighmcculloch:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 97.808% when pulling 867c447 on brentsnook:master into 707b966 on leighmcculloch:master.

@leighmcculloch leighmcculloch merged commit 8aec795 into leighmcculloch:master Jan 12, 2019
@leighmcculloch
Copy link
Owner

Thanks for fixing @brentsnook ! Sorry I forgot to merge this.

@leighmcculloch
Copy link
Owner

Released in v0.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brentsnook @coveralls @leighmcculloch