admin: Add --defaults options #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous iteration of the configuration dumping command did not allow dumping default values of services, since default values are set by the caller to the cfg_get* functions, thus there being no single truth to these option values or even names. This commit adds maps of the currently known configuration options, and the dump-config command uses these to figure out what are the defaults for each service. This is done with best-effort, because this list may become outdated as time goes on and new options are added. Until we have a single source of truth for these options, this will have to do.
uristdwarf
force-pushed
the
cfg-defaults-new
branch
from
511bc3e
to
2574c42
Compare
uristdwarf
force-pushed
the
dev
branch
4 times, most recently
from
be68d55
to
0459749
Compare
lgsilva3087
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
I understand this is a quick fix.
Please take into consideration that it introduces another place to update every time a default value changes.
Please, create the task to implement my proposal:
- class Option;
- class Configuration; //(singleton, map of Options)
- only access function cfg_get_* inside the previous classes.
- a function for each module to initialize the Options with default values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous iteration of the configuration dumping command did not allow dumping default values of services, since default values are set by the caller to the cfg_get* functions, thus there being no single truth to these option values or even names.
This commit adds maps of the currently known configuration options, and the dump-config command uses these to figure out what are the defaults for each service.
This is done with best-effort, because this list may become outdated as time goes on and new options are added. Until we have a single source of truth for these options, this will have to do.