Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.gitignore): Add .dockerignore and update .gitignore #48

Merged
merged 1 commit into from
May 6, 2024

Conversation

uristdwarf
Copy link
Collaborator

.dockerignore allows docker images building from the source context to ignore files, including build files and .git, which can balloon the context and significantly slow down image build times. The file is very similar to .gitignore, with minor changes specific for docker

On that note, .gitignore has been updated to not include files that are made by setup_machine.sh, and its aesthetics has been tidied up.

.dockerignore allows docker images building from the source context to
ignore files, including build files and .git, which can balloon the
context and significantly slow down image build times. The file is very
similar to .gitignore, with minor changes specific for docker

On that note, .gitignore has been updated to not include files that are
made by setup_machine.sh, and its aesthetics has been tidied up.
.dockerignore Show resolved Hide resolved
Copy link
Contributor

@antuan96314 antuan96314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uristdwarf uristdwarf requested a review from ictus4u April 24, 2024 12:02
@uristdwarf uristdwarf merged commit a289a18 into dev May 6, 2024
2 checks passed
@uristdwarf uristdwarf deleted the dockerignore branch May 6, 2024 11:13
ictus4u pushed a commit that referenced this pull request Jun 20, 2024
.dockerignore allows docker images building from the source context to
ignore files, including build files and .git, which can balloon the
context and significantly slow down image build times. The file is very
similar to .gitignore, with minor changes specific for docker

On that note, .gitignore has been updated to not include files that are
made by setup_machine.sh, and its aesthetics has been tidied up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants