mount: Fix gid in oplog output #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gid is encoded in some operations to indicate that the secondary groups were also sent. This is done by setting the most significative bit using this constant: constexpr std::uint32_t kSecondaryGroupsBit = (std::uint32_t)1 << 31; The oplog was printing the gid directly, without checking, showing 2147483650 (1 << 31) as gid. This commit checks the flag and prints the correct primary group.
ictus4u
approved these changes
May 9, 2024
aNeutrino
approved these changes
May 9, 2024
uristdwarf
pushed a commit
that referenced
this pull request
May 9, 2024
The gid is encoded in some operations to indicate that the secondary groups were also sent. This is done by setting the most significative bit using this constant: constexpr std::uint32_t kSecondaryGroupsBit = (std::uint32_t)1 << 31; The oplog was printing the gid directly, without checking, showing 2147483650 (1 << 31) as gid. This commit checks the flag and prints the correct primary group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gid is encoded in some operations to indicate that the secondary groups were also sent. This is done by setting the most significative bit using this constant:
constexpr std::uint32_t kSecondaryGroupsBit = (std::uint32_t)1 << 31;
The oplog was printing the gid directly, without checking, showing 2147483650 (1 << 31) as gid. This commit checks the flag and prints the correct primary group.