ladislas/bugfix/cleanup warnings #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladislas
requested review from
HPezz and
YannLocatelli
and removed request for
HPezz
Codecov Report
@@ Coverage Diff @@
## develop #1108 +/- ##
===========================================
+ Coverage 96.03% 96.06% +0.02%
===========================================
Files 138 138
Lines 3256 3251 -5
===========================================
- Hits 3127 3123 -4
+ Misses 129 128 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
YannLocatelli
approved these changes
Nov 9, 2022
ladislas
force-pushed
the
ladislas/bugfix/cleanup-warnings
branch
from
e3641e8
to
8e33950
Compare
YannLocatelli
requested changes
Nov 14, 2022
ladislas
force-pushed
the
ladislas/bugfix/cleanup-warnings
branch
4 times, most recently
from
0faddff
to
26f2f9c
Compare
HPezz
approved these changes
Nov 15, 2022
| @@ -161,7 +161,7 @@ TEST_F(CoreFontTest, displayNormalSentence) | |||
| { | |||
| constexpr uint8_t buff_size = 128; | |||
| char buff[buff_size] {}; | |||
| auto text_length = sprintf(buff, "Some text"); | |||
| auto text_length = snprintf(buff, buff_size, "Some text"); | |||
There was a problem hiding this comment.
Is "snprintf rather than sprintf" something to remind as a good practice ?
There was a problem hiding this comment.
yes, see:
https://www.gnu.org/software/libc/manual/html_node/Formatted-Output-Functions.html
Warning: The sprintf function can be dangerous because it can potentially output more characters than can fit in the allocation size of the string s. Remember that the field width given in a conversion specification is only a minimum value.
The snprintf function is similar to sprintf, except that the size argument specifies the maximum number of characters to produce.
The return value is the number of characters which would be generated for the given input, excluding the trailing null. If this value is greater than or equal to size, not all characters from the result have been stored in s. You should try again with a bigger output string.
There was a problem hiding this comment.
yes, see:
https://www.gnu.org/software/libc/manual/html_node/Formatted-Output-Functions.html
Warning: The sprintf function can be dangerous because it can potentially output more characters than can fit in the allocation size of the string s. Remember that the field width given in a conversion specification is only a minimum value.
The snprintf function is similar to sprintf, except that the size argument specifies the maximum number of characters to produce.
The return value is the number of characters which would be generated for the given input, excluding the trailing null. If this value is greater than or equal to size, not all characters from the result have been stored in s. You should try again with a bigger output string.
ladislas
force-pushed
the
ladislas/bugfix/cleanup-warnings
branch
from
2a24966
to
73652c9
Compare
YannLocatelli
approved these changes
Nov 17, 2022
ladislas
force-pushed
the
ladislas/bugfix/cleanup-warnings
branch
3 times, most recently
from
0923d97
to
0740937
Compare
… different signedness
…g' but the argument has type 'uint32_t' Using <cinttypes> and PRI... format specifiers allows code to compile without warning on both arm-none-eabi-gcc and clang/gcc on host machine. See for more information: - https://en.cppreference.com/w/cpp/io/c/fprintf - https://en.cppreference.com/w/cpp/header/cinttypes
…n-defined + NOLINT reinterpret_cast
- Do not use array subscript when the index is not an integer constant expression - Constructor does not initialize these fields: convertMCUBlocks - Performing an implicit widening conversion to type 'size_t' (aka 'unsigned long') of a multiplication performed in type 'unsigned int' - Performing an implicit widening conversion to type 'unsigned long' of a multiplication performed in type 'int' - xx is a magic number; consider replacing it with a named constant - Missing username/bug in TODO - Do not use C-style cast to convert between unrelated types - Result of multiplication in type 'unsigned int' is used as a pointer offset after an implicit widening conversion to type 'size_t' - Do not use array subscript when the index is not an integer constant expression
- warning: missing username/bug in TODO - warning: 4000 is a magic number; consider replacing it with a named constant
… provided for compatibility reasons only
ladislas
force-pushed
the
ladislas/bugfix/cleanup-warnings
branch
from
0740937
to
ca474ed
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes some (a lot) of sonarcloud, clang-tidy and compiler (gcc/clang) warnings/errors.