Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(coverage): Improve gcovr and lcovr coverage exclusion patterns #210

Merged
merged 6 commits into from
Apr 9, 2021
Merged

(coverage): Improve gcovr and lcovr coverage exclusion patterns #210

merged 6 commits into from
Apr 9, 2021

Conversation

ladislas
Copy link
Member

@ladislas ladislas commented Apr 8, 2021

The coverage exclusion patterns for gcovr and lcov where different with a lot of
redundant items. This PR removes unneed patterns and improves coverage statistics.

@ladislas
🔍 (coverage): Improve gcovr and lcovr coverage exclusion patterns
318144d 
The coverage exclusion patterns for gcovr and lcov where different with a lot of
redundant items. This PR removes unneed patterns and improves coverage statistics.
@codecov
Copy link

codecov bot commented Apr 8, 2021 •
edited
Loading

Codecov Report

Merging #210 (97bd9a7) into develop (cc7d6c4) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop      #210      +/-   ##
============================================
+ Coverage    99.76%   100.00%   +0.23%     
============================================
  Files           61        40      -21     
  Lines         1677       651    -1026     
============================================
- Hits          1673       651    -1022     
+ Misses           4         0       -4
Impacted Files Coverage Δ
drivers/LKCoreVideo/include/internal/LKCoreLTDC.h 100.00% <ø> (ø)
drivers/LKCoreVideo/source/LKCoreVideo.cpp 100.00% <ø> (ø)
...reVideo/include/internal/LKCoreLCDDriverOTM8009A.h 100.00% <100.00%> (ø)
...vers/LKCoreVideo/include/internal/LKCoreLTDCBase.h 100.00% <100.00%> (ø)
...ers/LKCoreVideo/source/LKCoreLCDDriverOTM8009A.cpp 100.00% <100.00%> (ø)
drivers/LKCoreVideo/source/LKCoreLTDC.cpp 100.00% <100.00%> (ø)
drivers/LKCoreFatFs/include/LKCoreFatFsBase.h
...LKCoreLightSensor/tests/LKCoreLightSensor_test.cpp
...ibs/LKCalculatorKit/tests/LKCalculatorKit_test.cpp
...LKCoreVideo/tests/LKCoreLCDDriverOTM8009A_test.cpp
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc7d6c4...97bd9a7. Read the comment docs.

@ladislas ladislas force-pushed the ladislas/bugfix/fix-coverage-reports branch 2 times, most recently from 9967391 to 45d9055 Compare April 8, 2021 15:00
@ladislas ladislas force-pushed the ladislas/bugfix/fix-coverage-reports branch 2 times, most recently from 189cc5b to 9e3c21d Compare April 9, 2021 12:27
YannLocatelli
YannLocatelli approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@YannLocatelli YannLocatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code fonctionnel sur le robot ✅

Il y a juste quelques warnings à corriger lors des tests du LTDC, parce que des EXPECT_CALL n'ont pas été mis en place

drivers/LKCoreVideo/source/LKCoreLCDDriverOTM8009A.cpp Show resolved Hide resolved
drivers/LKCoreVideo/tests/LKCoreLTDC_test.cpp Show resolved Hide resolved
drivers/LKCoreVideo/include/internal/LKCoreLTDC.h Outdated Show resolved Hide resolved
@ladislas ladislas force-pushed the ladislas/bugfix/fix-coverage-reports branch from 9e3c21d to 53532cc Compare April 9, 2021 14:32
@ladislas
♻️ (otm): Move backlight pwm period setup to initialize method
789b297 
This fixes the issue with branch coverage in constructor
@ladislas
♻️ (ltdc): Simplify interface, implementation and mock
220b5c1 
This commit simplifies the LTDC interface, implementation and mock.

This commit fixes the branch code coverage that was not reached in the
constructor.

It also hides implementation details
@ladislas
♻️ (ltdc): Move configureLayer implementation to initialize method
512f3e5 
This is done to simplify the source code, the interface & mocks and helps
not forget to call the function during initialization.

As both methods were called one after the other, it doesn't make sense
to have to different calls.

This further simplifies the LTDC interface
@ladislas
♻️ (ltdc): Move initializationRCCPeriphClock test to initializationSe…
97bd9a7 
…quence
@ladislas ladislas force-pushed the ladislas/bugfix/fix-coverage-reports branch from 53532cc to 97bd9a7 Compare April 9, 2021 14:33
@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ladislas ladislas merged commit ab6a647 into develop Apr 9, 2021
@ladislas ladislas deleted the ladislas/bugfix/fix-coverage-reports branch April 9, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YannLocatelli YannLocatelli YannLocatelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladislas @YannLocatelli