Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ladislas/feature/improve span #331

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Conversation

ladislas
Copy link
Member

@ladislas ladislas commented Sep 2, 2021

  • 🔧 (cmake): Add mbed-os/platform/cxxsupport to include_directories
  • ♻️ (cxxsupport): Refactor lstd::span

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #331 (97e89d8) into develop (1c5fb92) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #331   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           52        52           
  Lines          916       916           
=========================================
  Hits           916       916           
Impacted Files Coverage Δ
include/cxxsupport/lstd_span 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5fb92...97e89d8. Read the comment docs.

- use as much std:: as possible
- replace mbed_assert with static_assert
- explicitly use mbed mstd::
@ladislas ladislas force-pushed the ladislas/feature/improve-span branch from 49125cb to 97e89d8 Compare September 3, 2021 08:35
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

.map & .bin files analysis report

Versions

  • base: develop:1c5fb92 with mbed-os-6.14.0
  • head: ladislas/feature/improve-span:97e89d8 with mbed-os-6.14.0

Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Static RAM (base/head) Static RAM Δ Total Flash (base/head) Total Flash Δ
LekaOS ✔️ 12736 / 12736 ø 78276 / 78276 ø
certs_emc_ble_bt_lcd_led_motors ✔️ 30496 / 30496 ø 231332 / 231332 ø
certs_emc_ble_led_motors ✔️ 25400 / 25400 ø 183812 / 183812 ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 23152 / 23152 ø 148656 / 148656 ø
certs_emc_lcd_led_motors ✔️ 15880 / 15880 ø 87080 / 87080 ø
hardware_motors_test_reduction_and_wheels ✔️ 24808 / 24808 ø 179900 / 179900 ø
spike_lk_ble ✔️ 24112 / 24112 ø 177404 / 177404 ø
spike_lk_bluetooth ✔️ 12736 / 12736 ø 81284 / 81284 ø
spike_lk_cg_animations ✔️ 25728 / 25728 ø 136676 / 136676 ø
spike_lk_file_manager ✔️ 15176 / 15176 ø 119120 / 119120 ø
spike_lk_lcd ✔️ 25360 / 25360 ø 133100 / 133100 ø
spike_lk_led ✔️ 14656 / 14656 ø 85636 / 85636 ø
spike_lk_log_kit ✔️ 12928 / 12928 ø 80580 / 80580 ø
spike_lk_motors ✔️ 12816 / 12816 ø 81412 / 81412 ø
spike_lk_qspi ✔️ 12776 / 12776 ø 84612 / 84612 ø
spike_lk_rfid ✔️ 12736 / 12736 ø 81028 / 81028 ø
spike_lk_sensors_battery ✔️ 15392 / 15392 ø 121628 / 121628 ø
spike_lk_sensors_light ✔️ 12776 / 12776 ø 80132 / 80132 ø
spike_lk_sensors_microphone ✔️ 12776 / 12776 ø 80324 / 80324 ø
spike_lk_sensors_temperature_humidity ✔️ 12760 / 12760 ø 86340 / 86340 ø
spike_lk_sensors_touch ✔️ 12888 / 12888 ø 88388 / 88388 ø
spike_lk_wifi ✔️ 16096 / 16096 ø 125424 / 125424 ø
spike_mbed_blinky ✔️ 11120 / 11120 ø 54680 / 54680 ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 12840 / 12840 ø 78340 / 78340 ø
spike_stl_cxxsupport ✔️ 12800 / 12800 ø 79428 / 79428 ø

Map files diff output

Click to show diff list

No differenes where found in map files.

@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ladislas ladislas merged commit 99d948d into develop Sep 3, 2021
@ladislas ladislas deleted the ladislas/feature/improve-span branch September 3, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant