-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flash Memory - Spike #340
Flash Memory - Spike #340
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #340 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 55 62 +7
Lines 986 1092 +106
==========================================
+ Hits 986 1092 +106
Continue to review full report at Codecov.
|
3dcd778
to
eab36f7
Compare
8838a3a
to
03585ba
Compare
eab36f7
to
b870e94
Compare
4f125c3
to
d4c020d
Compare
0092866
to
30ebd5c
Compare
3fad967
to
ccffca4
Compare
waitForChipAvailable(); | ||
if (chipIsNotAvailable()) { | ||
return; | ||
} | ||
_qspi.sendCommand(command::erase_chip, -1, tx_buffer, 0, rx_buffer, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En refaisant le diagramme, il y a beaucoup de pattern similaire (4)
- Attendre que la chip est disponible
- Vérifier si il est disponible
- Si disponible, Envoyer la commande simple (sans écriture ni lecture attendue)
On peut donc faire une méthode privée du style
void CoreFlashManagerIS25LP016D::sendSimpleCommand(uint8_t command){
waitForChipAvailable();
if (chipIsNotAvailable()) {
return;
}
_qspi.sendCommand(command, -1, tx_buffer, 0, rx_buffer, 0);
}
df40f06
to
e5fb735
Compare
Implementation of the specific external flash memory used on robot
FlashManager handle operations between MCU and flash by reading/writing/sending commands to flash registers :children_crossing: (is25lp): Simplify and using flash::is25lp as namespace :art: (is25lp): Seperate enableWrite and writeIsNotEnabled :recycle: (is25lp): Add sendSimpleCommand For commands without writing or reading in registers
e5fb735
to
f27b569
Compare
Kudos, SonarCloud Quality Gate passed! |
.map & .bin files analysis reportVersions 🔖
Summary 📝Click to show summary
Map files diff output 🗺️Click to show diff list
|
Use #339