Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📌 (mcuboot): Upgrade to v1.8.0 #416

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

ladislas
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #416 (3eb117c) into develop (f82bf1d) will not change coverage.
The diff coverage is n/a.

❗ Current head 3eb117c differs from pull request most recent head b36d78a. Consider uploading reports for the commit b36d78a to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #416   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           66        66           
  Lines         1188      1188           
=========================================
  Hits          1188      1188           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856d285...b36d78a. Read the comment docs.

@ladislas ladislas force-pushed the ladislas/feature/mcuboot-upgrade-v1.8.0 branch from fef988a to 7a32574 Compare January 17, 2022 22:01
@github-actions
Copy link

github-actions bot commented Jan 17, 2022

File comparision analysis report

🔖 Info

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 58328 (2%) ø 11400 (2%) ø
bootloader ✔️ 95024 (4%)
93328 (4%)
📉
-1696 (-1%)
26200 (4%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ 234668 (11%) ø 30056 (5%) ø
certs_emc_ble_led_motors ✔️ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 177960 (8%) ø 24360 (4%) ø
spike_lk_ble ✔️ 162616 (7%) ø 22792 (4%) ø
spike_lk_bluetooth ✔️ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ 141064 (6%) ø 24464 (4%) ø
spike_lk_file_manager ✔️ 109588 (5%) ø 13672 (2%) ø
spike_lk_file_reception ✔️ 328916 (15%) ø 19312 (3%) ø
spike_lk_flash_memory ✔️ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ 136928 (6%) ø 24016 (4%) ø
spike_lk_led ✔️ 65744 (3%) ø 13392 (2%) ø
spike_lk_log_kit ✔️ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ 62528 (2%) ø 11488 (2%) ø
spike_lk_rfid ✔️ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ 60280 (2%) ø 11440 (2%) ø
spike_lk_sensors_light ✔️ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ 68600 (3%) ø 11432 (2%) ø
spike_lk_update_process_app_base ✔️ 121572 (5%)
121348 (5%)
📉
-224 (0%)
15288 (2%) ø
spike_lk_update_process_app_update ✔️ 77720 (3%)
77632 (3%)
📉
-88 (0%)
12352 (2%) ø
spike_lk_wifi ✔️ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
bootloader (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/bootloader-map.txt	2022-01-20 14:28:36.028076667 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/bootloader-map.txt	2022-01-20 14:28:36.248092479 +0000
@@ -1,18 +1,18 @@
 | Module                 |         .text |       .data |          .bss |
 |------------------------|---------------|-------------|---------------|
-| [fill]                 |     156(+156) |       4(+4) |       28(+28) |
+| [fill]                 |     146(+146) |       4(+4) |       28(+28) |
 | [lib]/CoreBattery.a    |     146(+146) |       0(+0) |         0(+0) |
-| [lib]/bootutil.a       |   6592(+6592) |     16(+16) | 13816(+13816) |
+| [lib]/bootutil.a       |   5898(+5898) |     16(+16) | 13816(+13816) |
 | [lib]/c.a              | 27020(+27020) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a            |   3116(+3116) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a | 47468(+47468) |   512(+512) |   8286(+8286) |
 | [lib]/misc             |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |         0(+0) |       0(+0) |         0(+0) |
 | default_bd.cpp.obj     |     242(+242) |       0(+0) |     568(+568) |
 | main.cpp.obj           |     452(+452) |       0(+0) |     120(+120) |
 | signing_keys.c.obj     |         0(+0) |       0(+0) |         0(+0) |
-| Subtotals              | 85412(+85412) | 3008(+3008) | 22904(+22904) |
+| Subtotals              | 84708(+84708) | 3008(+3008) | 22904(+22904) |
 Total Static RAM memory (data + bss): 25912(+25912) bytes
-Total Flash memory (text + data): 88420(+88420) bytes
+Total Flash memory (text + data): 87716(+87716) bytes
 
Flash used: 93328&nbsp;(4%) / total: 2097152
SRAM used: 26200&nbsp;(4%) / total: 524288
spike_lk_update_process_app_base (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_update_process_app_base-map.txt	2022-01-20 14:28:47.868940002 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_update_process_app_base-map.txt	2022-01-20 14:28:48.108957193 +0000
@@ -1,20 +1,20 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       168(+168) |       0(+0) |       38(+38) |
+| [fill]                  |       220(+220) |       0(+0) |       38(+38) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/FileSystemKit.a   |       574(+574) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
-| [lib]/bootutil.a        |     1398(+1398) |     12(+12) |     132(+132) |
+| [lib]/bootutil.a        |     1282(+1282) |     12(+12) |     132(+132) |
 | [lib]/c.a               |   41120(+41120) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     3276(+3276) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  |   61310(+61310) |   524(+524) | 10341(+10341) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |           0(+0) |       0(+0) |         0(+0) |
 | main.cpp.obj            |       998(+998) |       0(+0) |   1252(+1252) |
-| Subtotals               | 110036(+110036) | 3112(+3112) | 11888(+11888) |
+| Subtotals               | 109972(+109972) | 3112(+3112) | 11888(+11888) |
 Total Static RAM memory (data + bss): 15000(+15000) bytes
-Total Flash memory (text + data): 113148(+113148) bytes
+Total Flash memory (text + data): 113084(+113084) bytes
 
Flash used: 121348&nbsp;(5%) / total: 2097152
SRAM used: 15288&nbsp;(2%) / total: 524288
spike_lk_update_process_app_update (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_update_process_app_update-map.txt	2022-01-20 14:28:48.388977250 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_update_process_app_update-map.txt	2022-01-20 14:28:48.604992722 +0000
@@ -1,16 +1,16 @@
 | Module                 |         .text |       .data |        .bss |
 |------------------------|---------------|-------------|-------------|
-| [fill]                 |     104(+104) |       4(+4) |     24(+24) |
+| [fill]                 |     146(+146) |       4(+4) |     24(+24) |
 | [lib]/HelloWorld.a     |       94(+94) |       0(+0) |       0(+0) |
-| [lib]/bootutil.a       |   1190(+1190) |     12(+12) |   132(+132) |
+| [lib]/bootutil.a       |   1148(+1148) |     12(+12) |   132(+132) |
 | [lib]/c.a              | 26996(+26996) | 2472(+2472) |     58(+58) |
 | [lib]/gcc.a            |   3116(+3116) |       0(+0) |       0(+0) |
 | [lib]/mbed-os-static.a | 38058(+38058) |   508(+508) | 8254(+8254) |
 | [lib]/misc             |     188(+188) |       4(+4) |     28(+28) |
 | [lib]/nosys.a          |       32(+32) |       0(+0) |       0(+0) |
 | [lib]/stdc++.a         |         0(+0) |       0(+0) |       0(+0) |
 | main.cpp.obj           |     402(+402) |       0(+0) |   568(+568) |
 | Subtotals              | 70180(+70180) | 3000(+3000) | 9064(+9064) |
 Total Static RAM memory (data + bss): 12064(+12064) bytes
 Total Flash memory (text + data): 73180(+73180) bytes
 
Flash used: 77632&nbsp;(3%) / total: 2097152
SRAM used: 12352&nbsp;(2%) / total: 524288

@github-actions
Copy link

github-actions bot commented Jan 17, 2022

File comparision analysis report

🔖 Info

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 82200 (3%) ø 17472 (3%) ø
bootloader ✔️ 95024 (4%)
93328 (4%)
📉
-1696 (-1%)
26200 (4%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ 251132 (11%) ø 36144 (6%) ø
certs_emc_ble_led_motors ✔️ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 194032 (9%) ø 30384 (5%) ø
spike_lk_ble ✔️ 183688 (8%) ø 28856 (5%) ø
spike_lk_bluetooth ✔️ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ 149336 (7%) ø 30464 (5%) ø
spike_lk_file_manager ✔️ 132396 (6%) ø 19912 (3%) ø
spike_lk_file_reception ✔️ 333692 (15%) ø 25272 (4%) ø
spike_lk_flash_memory ✔️ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ 149808 (7%) ø 30088 (5%) ø
spike_lk_led ✔️ 88808 (4%) ø 19400 (3%) ø
spike_lk_log_kit ✔️ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ 86576 (4%) ø 17552 (3%) ø
spike_lk_rfid ✔️ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ 85088 (4%) ø 17512 (3%) ø
spike_lk_sensors_light ✔️ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ 85336 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ 92248 (4%) ø 17632 (3%) ø
spike_lk_update_process_app_base ✔️ 144052 (6%)
143764 (6%)
📉
-288 (0%)
21352 (4%) ø
spike_lk_update_process_app_update ✔️ 101120 (4%)
100968 (4%)
📉
-152 (0%)
18472 (3%) ø
spike_lk_wifi ✔️ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list
bootloader (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-ON/bootloader-map.txt	2022-01-20 14:29:53.621983409 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/bootloader-map.txt	2022-01-20 14:29:53.841984608 +0000
@@ -1,18 +1,18 @@
 | Module                 |         .text |       .data |          .bss |
 |------------------------|---------------|-------------|---------------|
-| [fill]                 |     156(+156) |       4(+4) |       28(+28) |
+| [fill]                 |     146(+146) |       4(+4) |       28(+28) |
 | [lib]/CoreBattery.a    |     146(+146) |       0(+0) |         0(+0) |
-| [lib]/bootutil.a       |   6592(+6592) |     16(+16) | 13816(+13816) |
+| [lib]/bootutil.a       |   5898(+5898) |     16(+16) | 13816(+13816) |
 | [lib]/c.a              | 27020(+27020) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a            |   3116(+3116) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a | 47468(+47468) |   512(+512) |   8286(+8286) |
 | [lib]/misc             |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |         0(+0) |       0(+0) |         0(+0) |
 | default_bd.cpp.obj     |     242(+242) |       0(+0) |     568(+568) |
 | main.cpp.obj           |     452(+452) |       0(+0) |     120(+120) |
 | signing_keys.c.obj     |         0(+0) |       0(+0) |         0(+0) |
-| Subtotals              | 85412(+85412) | 3008(+3008) | 22904(+22904) |
+| Subtotals              | 84708(+84708) | 3008(+3008) | 22904(+22904) |
 Total Static RAM memory (data + bss): 25912(+25912) bytes
-Total Flash memory (text + data): 88420(+88420) bytes
+Total Flash memory (text + data): 87716(+87716) bytes
 
Flash used: 93328&nbsp;(4%) / total: 2097152
SRAM used: 26200&nbsp;(4%) / total: 524288
spike_lk_update_process_app_base (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_update_process_app_base-map.txt	2022-01-20 14:30:06.014050683 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_update_process_app_base-map.txt	2022-01-20 14:30:06.278052137 +0000
@@ -1,22 +1,22 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       224(+224) |       0(+0) |       38(+38) |
+| [fill]                  |       212(+212) |       0(+0) |       38(+38) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileSystemKit.a   |       574(+574) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
-| [lib]/bootutil.a        |     1398(+1398) |     12(+12) |     132(+132) |
+| [lib]/bootutil.a        |     1282(+1282) |     12(+12) |     132(+132) |
 | [lib]/c.a               |   41008(+41008) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  |   68778(+68778) |   524(+524) | 10385(+10385) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5424(+5424) |       8(+8) |       44(+44) |
 | main.cpp.obj            |     3334(+3334) |       0(+0) |   7212(+7212) |
-| Subtotals               | 129448(+129448) | 3120(+3120) | 17936(+17936) |
+| Subtotals               | 129320(+129320) | 3120(+3120) | 17936(+17936) |
 Total Static RAM memory (data + bss): 21056(+21056) bytes
-Total Flash memory (text + data): 132568(+132568) bytes
+Total Flash memory (text + data): 132440(+132440) bytes
 
Flash used: 143764&nbsp;(6%) / total: 2097152
SRAM used: 21352&nbsp;(4%) / total: 524288
spike_lk_update_process_app_update (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_update_process_app_update-map.txt	2022-01-20 14:30:06.578053790 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_update_process_app_update-map.txt	2022-01-20 14:30:06.806055046 +0000
@@ -1,18 +1,18 @@
 | Module                  |         .text |       .data |          .bss |
 |-------------------------|---------------|-------------|---------------|
-| [fill]                  |     160(+160) |       4(+4) |       20(+20) |
+| [fill]                  |     138(+138) |       4(+4) |       20(+20) |
 | [lib]/CriticalSection.a |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/bootutil.a        |   1190(+1190) |     12(+12) |     132(+132) |
+| [lib]/bootutil.a        |   1148(+1148) |     12(+12) |     132(+132) |
 | [lib]/c.a               | 27616(+27616) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a             |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |     360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 45434(+45434) |   508(+508) |   8294(+8294) |
 | [lib]/misc              |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |   5424(+5424) |       8(+8) |       44(+44) |
 | main.cpp.obj            |   2866(+2866) |       0(+0) |   6592(+6592) |
-| Subtotals               | 90520(+90520) | 3008(+3008) | 15168(+15168) |
+| Subtotals               | 90456(+90456) | 3008(+3008) | 15168(+15168) |
 Total Static RAM memory (data + bss): 18176(+18176) bytes
-Total Flash memory (text + data): 93528(+93528) bytes
+Total Flash memory (text + data): 93464(+93464) bytes
 
Flash used: 100968&nbsp;(4%) / total: 2097152
SRAM used: 18472&nbsp;(3%) / total: 524288

@ladislas ladislas linked an issue Jan 19, 2022 that may be closed by this pull request
Copy link
Member

@YannLocatelli YannLocatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validé:

Pour aller plus loin à propos de la database commune:

@ladislas ladislas force-pushed the ladislas/feature/mcuboot-upgrade-v1.8.0 branch from 31a948f to 3eb117c Compare January 20, 2022 14:13
@ladislas ladislas force-pushed the ladislas/feature/mcuboot-upgrade-v1.8.0 branch from 3eb117c to b36d78a Compare January 20, 2022 14:22
@ladislas ladislas merged commit cf4768f into develop Jan 20, 2022
@ladislas ladislas deleted the ladislas/feature/mcuboot-upgrade-v1.8.0 branch January 20, 2022 14:23
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ladislas ladislas self-assigned this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin mcuboot to v1.8.0 (latest release)
2 participants