🐛 (interface): Forward declare RGB struct #469

ladislas · 2022-01-28T14:19:05Z

Running clang-tidy locally showed the issue. interface::LED depends on
RGB.h inside CoreLED, which is a bug, interfaces should never depend on
specifi implemetations.

The fix is to forward delcare struct RGB inside the interface header so
that it is available to the drivers implementing the interface.

This also allows different implemtation of RGB.h to coexist depending on
the needs.

Running clang-tidy locally showed the issue. interface::LED depends on RGB.h inside CoreLED, which is a bug, interfaces should never depend on specifi implemetations. The fix is to forward delcare struct RGB inside the interface header so that it is available to the drivers implementing the interface. This also allows different implemtation of RGB.h to coexist depending on the needs.

codecov · 2022-01-28T14:21:29Z

Codecov Report

Merging #469 (b0de08a) into develop (c331cf8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop      #469   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           76        76           
  Lines         1262      1262           
=========================================
  Hits          1262      1262

Impacted Files	Coverage Δ
include/interface/drivers/LED.h	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c331cf8...b0de08a. Read the comment docs.

github-actions · 2022-01-28T14:24:33Z

File comparision analysis report

🔖 Info

Flash: 2 097 152 Bytes (2048 KiB) / SRAM: 524 288 Bytes (512 KiB)
base: develop / c331cf8 + mbed-os-6.15.1+fixes + -std=c++20
head: ladislas/bugfix/led-rgb-forward-declare / b0de08a + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	63816 (3%)	ø	12184 (2%)	ø
bootloader	✔️	✅	✅	95272 (4%)	ø	26792 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	249184 (11%)	ø	29240 (5%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	174568 (8%)	ø	24952 (4%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	148840 (7%)	ø	22528 (4%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	177960 (8%)	ø	24360 (4%)	ø
spike_lk_ble	✔️	✅	✅	156328 (7%)	ø	22984 (4%)	ø
spike_lk_bluetooth	✔️	✅	✅	73256 (3%)	ø	11448 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	141112 (6%)	ø	24464 (4%)	ø
spike_lk_file_reception	✔️	✅	✅	328916 (15%)	ø	19312 (3%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_lcd	✔️	✅	✅	136976 (6%)	ø	24024 (4%)	ø
spike_lk_led	✔️	✅	✅	65744 (3%)	ø	13392 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	68528 (3%)	ø	11912 (2%)	ø
spike_lk_motors	✔️	✅	✅	62528 (2%)	ø	11488 (2%)	ø
spike_lk_rfid	✔️	✅	✅	73072 (3%)	ø	11448 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	63072 (3%)	ø	11984 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	66968 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	121348 (5%)	ø	15288 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

sonarcloud · 2022-01-28T14:24:53Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

github-actions · 2022-01-28T14:25:34Z

File comparision analysis report

🔖 Info

Flash: 2 097 152 Bytes (2048 KiB) / SRAM: 524 288 Bytes (512 KiB)
base: develop / c331cf8 + mbed-os-6.15.1+fixes + -std=c++20
head: ladislas/bugfix/led-rgb-forward-declare / b0de08a + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	87456 (4%)	ø	18248 (3%)	ø
bootloader	✔️	✅	✅	95272 (4%)	ø	26792 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	256728 (12%)	ø	35272 (6%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	191600 (9%)	ø	30976 (5%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	165248 (7%)	ø	28680 (5%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	194032 (9%)	ø	30384 (5%)	ø
spike_lk_ble	✔️	✅	✅	175376 (8%)	ø	28976 (5%)	ø
spike_lk_bluetooth	✔️	✅	✅	91192 (4%)	ø	17472 (3%)	ø
spike_lk_cg_animations	✔️	✅	✅	149384 (7%)	ø	30464 (5%)	ø
spike_lk_file_reception	✔️	✅	✅	333692 (15%)	ø	25272 (4%)	ø
spike_lk_flash_memory	✔️	✅	✅	87352 (4%)	ø	17512 (3%)	ø
spike_lk_lcd	✔️	✅	✅	149792 (7%)	ø	30096 (5%)	ø
spike_lk_led	✔️	✅	✅	88808 (4%)	ø	19400 (3%)	ø
spike_lk_log_kit	✔️	✅	✅	92000 (4%)	ø	18168 (3%)	ø
spike_lk_motors	✔️	✅	✅	86576 (4%)	ø	17552 (3%)	ø
spike_lk_rfid	✔️	✅	✅	91008 (4%)	ø	17472 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	86744 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	84584 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	85336 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90896 (4%)	ø	17496 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	92248 (4%)	ø	17632 (3%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	83224 (3%)	ø	17592 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	143764 (6%)	ø	21352 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100968 (4%)	ø	18472 (3%)	ø
spike_lk_wifi	✔️	✅	✅	131280 (6%)	ø	20832 (3%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84688 (4%)	ø	18448 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	84000 (4%)	ø	17536 (3%)	ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

YannLocatelli

In that case, interface::Graphics and interface::Font in CoreVideo have to be updated too since they depend on implementation of CGColor and CGPixel.

YannLocatelli requested changes Jan 28, 2022

View reviewed changes

This was referenced Jan 28, 2022

Remove CGColor and CGPixel in interface::Graphics #471

Closed

Remove CGColor and CGPixel in interface::Font #472

Closed

ladislas merged commit ffeeff5 into develop Jan 28, 2022

ladislas deleted the ladislas/bugfix/led-rgb-forward-declare branch January 28, 2022 21:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 (interface): Forward declare RGB struct #469

🐛 (interface): Forward declare RGB struct #469

ladislas commented Jan 28, 2022

codecov bot commented Jan 28, 2022

github-actions bot commented Jan 28, 2022

sonarcloud bot commented Jan 28, 2022

github-actions bot commented Jan 28, 2022

YannLocatelli left a comment

🐛 (interface): Forward declare RGB struct #469

🐛 (interface): Forward declare RGB struct #469

Conversation

ladislas commented Jan 28, 2022

codecov bot commented Jan 28, 2022

Codecov Report

github-actions bot commented Jan 28, 2022

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

sonarcloud bot commented Jan 28, 2022

github-actions bot commented Jan 28, 2022

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

YannLocatelli left a comment

Choose a reason for hiding this comment