Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ladislas/feature/remove LK prefix #507

Merged
merged 3 commits into from
Feb 28, 2022
Merged

ladislas/feature/remove LK prefix #507

merged 3 commits into from
Feb 28, 2022

Conversation

ladislas
Copy link
Member

  • 🗑️ (libs): Remove LKCalculatorKit
  • 🚚 (libs): Rename LKAnimationKit to UIAnimationKit

@ladislas
🗑️ (libs): Remove LKCalculatorKit
c55273f 
This kit was used as an example for TDD and directory organisation.

Now that the new practices are well applied, it can be safely removed to
reduce technical debt.
@ladislas
🚚 (libs): Rename LKAnimationKit to UIAnimationKit
963b68d 
Following #420 and d95ae59 we are
removing the LK prefix from libs and drivers

In this case we add the UI prefix as "animation" can mean a lot of
things: leds animation, robot animations, etc.
@codecov
Copy link

codecov bot commented Feb 28, 2022 •
edited
Loading

Codecov Report

Merging #507 (28dce01) into develop (66cdcef) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #507   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           96        94    -2     
  Lines         1478      1469    -9     
=========================================
- Hits          1478      1469    -9
Impacted Files Coverage Δ
libs/UIAnimationKit/include/internal/CGAnimation.h 100.00% <ø> (ø)
libs/UIAnimationKit/source/UIAnimationKit.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66cdcef...28dce01. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 28, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 137588 (52%) 124556 (47%) 29360 (5%)
os 74772 (4%) 1489900 (95%) 12328 (2%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 74772 (3%) ø 12328 (2%) ø
bootloader ✔️ ✅ ✅ 137588 (6%) ø 29360 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 249184 (11%) ø 29240 (5%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 177960 (8%) ø 24360 (4%) ø
spike_lk_ble ✔️ ✅ ✅ 173124 (8%) ø 23352 (4%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ ✅ ❌ 141112 (6%) ø 24464 (4%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65584 (3%) ø 13624 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 324516 (15%) ø 27520 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 136976 (6%) ø 24024 (4%) ø
spike_lk_led ✔️ ✅ ✅ 65744 (3%) ø 13392 (2%) ø
spike_lk_led_kit ✔️ ✅ ✅ 68680 (3%) ø 14160 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62528 (2%) ø 11488 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 63072 (3%) ø 11984 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 121348 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_cg_animations (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_cg_animations-map.txt	2022-02-28 10:05:43.042752506 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_cg_animations-map.txt	2022-02-28 10:05:43.278764638 +0000
@@ -1,19 +1,19 @@
 | Module                 |           .text |       .data |          .bss |
 |------------------------|-----------------|-------------|---------------|
 | [fill]                 |       156(+156) |       7(+7) |       34(+34) |
 | [lib]/CoreFs.a         |         40(+40) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a   |       804(+804) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a      |     6510(+6510) |       1(+1) |   4160(+4160) |
 | [lib]/HelloWorld.a     |         94(+94) |       0(+0) |         0(+0) |
-| [lib]/LKAnimationKit.a |       540(+540) |       0(+0) |         0(+0) |
+| [lib]/UIAnimationKit.a |       540(+540) |       0(+0) |         0(+0) |
 | [lib]/c.a              |   36984(+36984) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a            |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a |   60432(+60432) |   460(+460) | 10269(+10269) |
 | [lib]/misc             |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |     5356(+5356) |       8(+8) |       44(+44) |
 | main.cpp.obj           |       980(+980) |     52(+52) |   6440(+6440) |
 | Subtotals              | 119264(+119264) | 3104(+3104) | 21072(+21072) |
 Total Static RAM memory (data + bss): 24176(+24176) bytes
 Total Flash memory (text + data): 122368(+122368) bytes
 






      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @github-actions





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

      

      
            github-actions
  bot

      

      

      commented


        Feb 28, 2022


      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
        
      Loading

      
    
  



    


  





      


        


  
    

      
          
File comparision analysis report


🔖 Info







Target
Flash Used (%)
Flash Available (%)
Static RAM (%)






bootloader
137588 (52%)
124556 (47%)
29360 (5%)




os
88648 (5%)
1476024 (94%)
18352 (3%)







Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |





📝 Summary



Click to show summary

    

  • ✔️ - existing target
    • 

  • ✨ - new target
    • 

  • ⚰️ - deleted target
    • 

  • ✅ - files are the same
    • 

  • ❌ - files are different
    • 







Target
Status
.bin
.map
Total Flash (base/head)
Total Flash Δ
Static RAM (base/head)
Static RAM Δ






LekaOS
✔️
✅
✅
88648 (4%)
ø
18352 (3%)
ø




bootloader
✔️
✅
✅
137588 (6%)
ø
29360 (5%)
ø




certs_emc_ble_bt_lcd_led_motors
✔️
✅
✅
256728 (12%)
ø
35272 (6%)
ø




certs_emc_ble_led_motors
✔️
✅
✅
191600 (9%)
ø
30976 (5%)
ø




certs_emc_bt_lcd_qspi_rfid_touch_wifi
✔️
✅
✅
165248 (7%)
ø
28680 (5%)
ø




certs_emc_lcd_led_motors
✔️
✅
✅
91928 (4%)
ø
16168 (3%)
ø




hardware_motors_test_reduction_and_wheels
✔️
✅
✅
194032 (9%)
ø
30384 (5%)
ø




spike_lk_ble
✔️
✅
✅
182392 (8%)
ø
29304 (5%)
ø




spike_lk_bluetooth
✔️
✅
✅
91192 (4%)
ø
17472 (3%)
ø




spike_lk_cg_animations
✔️
✅
❌
149384 (7%)
ø
30464 (5%)
ø




spike_lk_color_kit
✔️
✅
✅
88800 (4%)
ø
19624 (3%)
ø




spike_lk_coreled
✔️
✅
✅
88556 (4%)
ø
19632 (3%)
ø




spike_lk_event_queue
✔️
✅
✅
84664 (4%)
ø
18136 (3%)
ø




spike_lk_file_reception
✔️
✅
✅
329452 (15%)
ø
33480 (6%)
ø




spike_lk_flash_memory
✔️
✅
✅
87352 (4%)
ø
17512 (3%)
ø




spike_lk_lcd
✔️
✅
✅
149792 (7%)
ø
30096 (5%)
ø




spike_lk_led
✔️
✅
✅
88808 (4%)
ø
19400 (3%)
ø




spike_lk_led_kit
✔️
✅
✅
88288 (4%)
ø
20216 (3%)
ø




spike_lk_log_kit
✔️
✅
✅
92000 (4%)
ø
18168 (3%)
ø




spike_lk_motors
✔️
✅
✅
86576 (4%)
ø
17552 (3%)
ø




spike_lk_rfid
✔️
✅
✅
91008 (4%)
ø
17472 (3%)
ø




spike_lk_sensors_battery
✔️
✅
✅
86744 (4%)
ø
18056 (3%)
ø




spike_lk_sensors_light
✔️
✅
✅
84584 (4%)
ø
17512 (3%)
ø




spike_lk_sensors_microphone
✔️
✅
✅
85336 (4%)
ø
17512 (3%)
ø




spike_lk_sensors_temperature_humidity
✔️
✅
✅
90896 (4%)
ø
17496 (3%)
ø




spike_lk_sensors_touch
✔️
✅
✅
92248 (4%)
ø
17632 (3%)
ø




spike_lk_ticker_timeout
✔️
✅
✅
83224 (3%)
ø
17592 (3%)
ø




spike_lk_update_process_app_base
✔️
✅
✅
143764 (6%)
ø
21352 (4%)
ø




spike_lk_update_process_app_update
✔️
✅
✅
100968 (4%)
ø
18472 (3%)
ø




spike_lk_wifi
✔️
✅
✅
131280 (6%)
ø
20832 (3%)
ø




spike_mbed_blinky
✔️
✅
✅
57968 (2%)
ø
11400 (2%)
ø




spike_mbed_watchdog_ticker_vs_thread
✔️
✅
✅
84688 (4%)
ø
18448 (3%)
ø




spike_stl_cxxsupport
✔️
✅
✅
84000 (4%)
ø
17536 (3%)
ø








🗺️ Map files diff output



Click to show diff list


spike_lk_cg_animations (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_cg_animations-map.txt	2022-02-28 10:03:53.231100886 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_cg_animations-map.txt	2022-02-28 10:03:53.467107453 +0000
@@ -1,21 +1,21 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
 | [fill]                  |       216(+216) |       7(+7) |       38(+38) |
 | [lib]/CoreFs.a          |         40(+40) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a    |       804(+804) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a       |     6510(+6510) |       1(+1) |   4160(+4160) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
-| [lib]/LKAnimationKit.a  |       508(+508) |       0(+0) |         0(+0) |
+| [lib]/UIAnimationKit.a  |       508(+508) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   37008(+37008) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  |   63972(+63972) |   460(+460) | 10305(+10305) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5864(+5864) |       8(+8) |       44(+44) |
 | main.cpp.obj            |     3184(+3184) |     52(+52) | 12400(+12400) |
 | Subtotals               | 125936(+125936) | 3104(+3104) | 27072(+27072) |
 Total Static RAM memory (data + bss): 30176(+30176) bytes
 Total Flash memory (text + data): 129040(+129040) bytes
 








      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @sonarcloud





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

      

      
            sonarcloud
  bot

      

      

      commented


        Feb 28, 2022


      
    


  





      


        


  
    

      
          
Kudos, SonarCloud Quality Gate passed!    Quality Gate passed


Bug A 0 Bugs

Vulnerability A 0 Vulnerabilities

Security Hotspot A 0 Security Hotspots

Code Smell A 0 Code Smells


100.0% 100.0% Coverage

0.0% 0.0% Duplication

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        

  

      

  YannLocatelli
  

  
          

            
                  YannLocatelli
  

            

            approved these changes


            
                
                  Feb 28, 2022
                
            
            
          


          



              
    View reviewed changes
  


          





          

  
  
  
              

                        

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

      @YannLocatelli

      
            YannLocatelli
  

      

      

      left a comment




      
    


  



                    

                        

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
UI peut prêter à confusion pour un écran qui ne permet pas d'interaction utilisateur.


Je suggère plutôt d'utiliser User Visualisation

    

  
  




                      

                    
  

    
  
    
    

  

  




                        

                      
                    








      

  
  
  




  








      

  
          

  

    
  

  



        @ladislas
  ladislas



        merged commit c5aa0ae
      into

      
  
    develop
  


    Feb 28, 2022

  







  

  
  

  
      @ladislas
  ladislas


    
    deleted the
    
      
        ladislas/feature/remove-LK-prefix
    
    branch

    
      March 11, 2022 16:00
    
    













  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
    




      

  

    
    

    
  

    Reviewers
  


    


        

          

  
      @YannLocatelli
  
    YannLocatelli



          
            
              
            
          
          YannLocatelli approved these changes

        


      






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




        
      

    

  
      

  

    

      2 participants
    

    

        
          @ladislas 
        
          @YannLocatelli