Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hugo/feature/Add Underwater animation #514

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

HPezz
Copy link
Contributor

@HPezz HPezz commented Mar 1, 2022

  • ✨ (animation): Add Underwater animation
  • 🎨 (spikes): Upgrade lk_led_kit

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #514 (1957d57) into develop (633575a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #514   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           96        96           
  Lines         1471      1471           
=========================================
  Hits          1471      1471           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633575a...1957d57. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 137588 (52%) 124556 (47%) 29360 (5%)
os 88648 (5%) 1476024 (94%) 18352 (3%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 88648 (4%) ø 18352 (3%) ø
bootloader ✔️ 137588 (6%) ø 29360 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ 256728 (12%) ø 35272 (6%) ø
certs_emc_ble_led_motors ✔️ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 194032 (9%) ø 30384 (5%) ø
spike_lk_ble ✔️ 182392 (8%) ø 29304 (5%) ø
spike_lk_bluetooth ✔️ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ 149384 (7%) ø 30464 (5%) ø
spike_lk_color_kit ✔️ 88800 (4%) ø 19624 (3%) ø
spike_lk_coreled ✔️ 88556 (4%) ø 19632 (3%) ø
spike_lk_event_queue ✔️ 84664 (4%) ø 18136 (3%) ø
spike_lk_file_reception ✔️ 329452 (15%) ø 33480 (6%) ø
spike_lk_filesystem_kit ✔️ 125948 (6%) ø 20280 (3%) ø
spike_lk_flash_memory ✔️ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ 149792 (7%) ø 30096 (5%) ø
spike_lk_led ✔️ 88808 (4%) ø 19400 (3%) ø
spike_lk_led_kit ✔️ 88224 (4%)
91984 (4%)
📈
3760 (4%)
20152 (3%)
20184 (3%)
📈
32 (0%)
spike_lk_log_kit ✔️ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ 86576 (4%) ø 17552 (3%) ø
spike_lk_rfid ✔️ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ 86744 (4%) ø 18056 (3%) ø
spike_lk_sensors_light ✔️ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ 85336 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ 92248 (4%) ø 17632 (3%) ø
spike_lk_ticker_timeout ✔️ 83224 (3%) ø 17592 (3%) ø
spike_lk_update_process_app_base ✔️ 143764 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ 100968 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_led_kit (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_led_kit-map.txt	2022-03-08 17:05:24.430136696 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_led_kit-map.txt	2022-03-08 17:05:24.690138950 +0000
@@ -1,19 +1,20 @@
 | Module                  |         .text |       .data |          .bss |
 |-------------------------|---------------|-------------|---------------|
-| [fill]                  |     148(+148) |       8(+8) |       32(+32) |
+| [fill]                  |     130(+130) |       8(+8) |       28(+28) |
+| [lib]/ColorKit.a        |     864(+864) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |       28(+28) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/LedKit.a          |       28(+28) |       0(+0) |         0(+0) |
+| [lib]/LedKit.a          |   2606(+2606) |       0(+0) |         0(+0) |
 | [lib]/c.a               | 26052(+26052) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a             |   7148(+7148) |       0(+0) |         0(+0) |
-| [lib]/m.a               |     360(+360) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a  | 34280(+34280) |   444(+444) |   9990(+9990) |
+| [lib]/m.a               |     564(+564) |       0(+0) |         0(+0) |
+| [lib]/mbed-os-static.a  | 34292(+34292) |   444(+444) |   9990(+9990) |
 | [lib]/misc              |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |   5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   4118(+4118) |       0(+0) |   6776(+6776) |
-| Subtotals               | 77908(+77908) | 2936(+2936) | 16928(+16928) |
-Total Static RAM memory (data + bss): 19864(+19864) bytes
-Total Flash memory (text + data): 80844(+80844) bytes
+| main.cpp.obj            |   4190(+4190) |       0(+0) |   6812(+6812) |
+| Subtotals               | 81620(+81620) | 2936(+2936) | 16960(+16960) |
+Total Static RAM memory (data + bss): 19896(+19896) bytes
+Total Flash memory (text + data): 84556(+84556) bytes
 
Flash used: 91984&nbsp;(4%) / total: 2097152
SRAM used: 20184&nbsp;(3%) / total: 524288

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 137588 (52%) 124556 (47%) 29360 (5%)
os 74772 (4%) 1489900 (95%) 12328 (2%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 74772 (3%) ø 12328 (2%) ø
bootloader ✔️ 137588 (6%) ø 29360 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ 249184 (11%) ø 29240 (5%) ø
certs_emc_ble_led_motors ✔️ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 177960 (8%) ø 24360 (4%) ø
spike_lk_ble ✔️ 173124 (8%) ø 23352 (4%) ø
spike_lk_bluetooth ✔️ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ 141112 (6%) ø 24464 (4%) ø
spike_lk_color_kit ✔️ 65584 (3%) ø 13624 (2%) ø
spike_lk_coreled ✔️ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_reception ✔️ 324516 (15%) ø 27520 (5%) ø
spike_lk_filesystem_kit ✔️ 102036 (4%) ø 14048 (2%) ø
spike_lk_flash_memory ✔️ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ 136976 (6%) ø 24024 (4%) ø
spike_lk_led ✔️ 65744 (3%) ø 13392 (2%) ø
spike_lk_led_kit ✔️ 69000 (3%)
73144 (3%)
📈
4144 (6%)
14160 (2%)
14192 (2%)
📈
32 (0%)
spike_lk_log_kit ✔️ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ 62528 (2%) ø 11488 (2%) ø
spike_lk_rfid ✔️ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ 63072 (3%) ø 11984 (2%) ø
spike_lk_sensors_light ✔️ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ 68600 (3%) ø 11432 (2%) ø
spike_lk_ticker_timeout ✔️ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ 121348 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_led_kit (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_led_kit-map.txt	2022-03-08 17:05:11.128977432 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_led_kit-map.txt	2022-03-08 17:05:11.332986740 +0000
@@ -1,17 +1,19 @@
 | Module                 |         .text |       .data |          .bss |
 |------------------------|---------------|-------------|---------------|
-| [fill]                 |     172(+172) |       8(+8) |       24(+24) |
+| [fill]                 |     124(+124) |       8(+8) |       20(+20) |
+| [lib]/ColorKit.a       |     864(+864) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a        |       28(+28) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a     |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/LedKit.a         |       28(+28) |       0(+0) |         0(+0) |
+| [lib]/LedKit.a         |   2606(+2606) |       0(+0) |         0(+0) |
 | [lib]/c.a              | 25296(+25296) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a            |   3276(+3276) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a | 30298(+30298) |   444(+444) |   9954(+9954) |
+| [lib]/m.a              |     204(+204) |       0(+0) |         0(+0) |
+| [lib]/mbed-os-static.a | 30728(+30728) |   444(+444) |   9954(+9954) |
 | [lib]/misc             |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |         0(+0) |       0(+0) |         0(+0) |
-| main.cpp.obj           |   2156(+2156) |       0(+0) |     880(+880) |
-| Subtotals              | 61568(+61568) | 2928(+2928) | 10944(+10944) |
-Total Static RAM memory (data + bss): 13872(+13872) bytes
-Total Flash memory (text + data): 64496(+64496) bytes
+| main.cpp.obj           |   2224(+2224) |       0(+0) |     916(+916) |
+| Subtotals              | 65664(+65664) | 2928(+2928) | 10976(+10976) |
+Total Static RAM memory (data + bss): 13904(+13904) bytes
+Total Flash memory (text + data): 68592(+68592) bytes
 
Flash used: 73144&nbsp;(3%) / total: 2097152
SRAM used: 14192&nbsp;(2%) / total: 524288

@HPezz HPezz force-pushed the hugo/feature/Add-Underwater-animation branch from 66fa7e4 to 3b665d7 Compare March 3, 2022 20:25
@HPezz HPezz marked this pull request as draft March 4, 2022 10:24
@HPezz HPezz force-pushed the hugo/feature/Add-Underwater-animation branch from 3b665d7 to 3829059 Compare March 7, 2022 10:58
@HPezz HPezz marked this pull request as ready for review March 7, 2022 11:02
@HPezz HPezz force-pushed the hugo/feature/Add-Underwater-animation branch 2 times, most recently from 9114d7e to 1957d57 Compare March 8, 2022 16:54
@ladislas ladislas force-pushed the hugo/feature/Add-Underwater-animation branch from 1957d57 to 28baedd Compare March 9, 2022 16:34
@ladislas ladislas merged commit 40217dc into develop Mar 9, 2022
@ladislas ladislas deleted the hugo/feature/Add-Underwater-animation branch March 9, 2022 16:34
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants