Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💫 (bootloader): Add charging animation LED blink #573

Merged

Conversation

HPezz
Copy link
Contributor

@HPezz HPezz commented Mar 15, 2022

No description provided.

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #573 (32730d8) into develop (dfa7518) will not change coverage.
The diff coverage is n/a.

❗ Current head 32730d8 differs from pull request most recent head 43daced. Consider uploading reports for the commit 43daced to get more accurate results

@@            Coverage Diff            @@
##           develop      #573   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       106           
  Lines         1636      1636           
=========================================
  Hits          1636      1636           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions
Copy link

github-actions bot commented Mar 15, 2022

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 140204 (53%) 121940 (46%) 29512 (5%)
os 212536 (13%) 1352136 (86%) 25128 (4%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 212536 (10%) ø 25128 (4%) ø
bootloader ✔️ 139036 (6%)
140204 (6%)
📈
1168 (0%)
29368 (5%)
29512 (5%)
📈
144 (0%)
certs_emc_ble_bt_lcd_led_motors ✔️ 250624 (11%) ø 29240 (5%) ø
certs_emc_ble_led_motors ✔️ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 177960 (8%) ø 24360 (4%) ø
spike_lk_ble ✔️ 173940 (8%) ø 23904 (4%) ø
spike_lk_bluetooth ✔️ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ 141176 (6%) ø 24464 (4%) ø
spike_lk_color_kit ✔️ 65584 (3%) ø 13624 (2%) ø
spike_lk_coreled ✔️ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_reception ✔️ 326904 (15%) ø 27576 (5%) ø
spike_lk_filesystem_kit ✔️ 103476 (4%) ø 14048 (2%) ø
spike_lk_flash_memory ✔️ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ 137552 (6%) ø 24016 (4%) ø
spike_lk_led ✔️ 65744 (3%) ø 13392 (2%) ø
spike_lk_led_kit ✔️ 100428 (4%) ø 14640 (2%) ø
spike_lk_log_kit ✔️ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ 62528 (2%) ø 11488 (2%) ø
spike_lk_rfid ✔️ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ 58560 (2%) ø 11424 (2%) ø
spike_lk_ticker_timeout ✔️ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ 122724 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
bootloader (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/bootloader-map.txt	2022-03-15 11:36:23.589006962 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/bootloader-map.txt	2022-03-15 11:36:23.817007180 +0000
@@ -1,19 +1,20 @@
 | Module                 |           .text |       .data |          .bss |
 |------------------------|-----------------|-------------|---------------|
-| [fill]                 |       190(+190) |       7(+7) |       32(+32) |
+| [fill]                 |       172(+172) |       7(+7) |       32(+32) |
 | [lib]/CoreBattery.a    |       472(+472) |       0(+0) |         0(+0) |
+| [lib]/CoreSPI.a        |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/FileSystemKit.a  |       694(+694) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a       |     5898(+5898) |     16(+16) | 13816(+13816) |
 | [lib]/c.a              |   42360(+42360) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a            |     3276(+3276) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a |   72164(+72164) |   528(+528) | 10919(+10919) |
+| [lib]/mbed-os-static.a |   72306(+72306) |   528(+528) | 10919(+10919) |
 | [lib]/misc             |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |           0(+0) |       0(+0) |         0(+0) |
 | default_bd.cpp.obj     |       242(+242) |       0(+0) |     568(+568) |
-| main.cpp.obj           |       712(+712) |       1(+1) |     492(+492) |
+| main.cpp.obj           |     1648(+1648) |       1(+1) |     636(+636) |
 | signing_keys.c.obj     |           0(+0) |       0(+0) |         0(+0) |
-| Subtotals              | 126228(+126228) | 3128(+3128) | 25952(+25952) |
-Total Static RAM memory (data + bss): 29080(+29080) bytes
-Total Flash memory (text + data): 129356(+129356) bytes
+| Subtotals              | 127316(+127316) | 3128(+3128) | 26096(+26096) |
+Total Static RAM memory (data + bss): 29224(+29224) bytes
+Total Flash memory (text + data): 130444(+130444) bytes
 
Flash used: 140204 (6%) / total: 2097152
SRAM used: 29512 (5%) / total: 524288

@github-actions
Copy link

github-actions bot commented Mar 15, 2022

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 140204 (53%) 121940 (46%) 29512 (5%)
os 222044 (14%) 1342628 (85%) 31136 (5%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 222044 (10%) ø 31136 (5%) ø
bootloader ✔️ 139036 (6%)
140204 (6%)
📈
1168 (0%)
29368 (5%)
29512 (5%)
📈
144 (0%)
certs_emc_ble_bt_lcd_led_motors ✔️ 258168 (12%) ø 35272 (6%) ø
certs_emc_ble_led_motors ✔️ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 194032 (9%) ø 30384 (5%) ø
spike_lk_ble ✔️ 183224 (8%) ø 29856 (5%) ø
spike_lk_bluetooth ✔️ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ 149448 (7%) ø 30464 (5%) ø
spike_lk_color_kit ✔️ 88800 (4%) ø 19624 (3%) ø
spike_lk_coreled ✔️ 88556 (4%) ø 19632 (3%) ø
spike_lk_event_queue ✔️ 84664 (4%) ø 18136 (3%) ø
spike_lk_file_reception ✔️ 331612 (15%) ø 33536 (6%) ø
spike_lk_filesystem_kit ✔️ 127580 (6%) ø 20216 (3%) ø
spike_lk_flash_memory ✔️ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ 150432 (7%) ø 30088 (5%) ø
spike_lk_led ✔️ 88808 (4%) ø 19400 (3%) ø
spike_lk_led_kit ✔️ 109636 (5%) ø 20648 (3%) ø
spike_lk_log_kit ✔️ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ 86576 (4%) ø 17552 (3%) ø
spike_lk_rfid ✔️ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ 87600 (4%) ø 18584 (3%) ø
spike_lk_sensors_light ✔️ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ 85336 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ 92248 (4%) ø 17632 (3%) ø
spike_lk_serial_number ✔️ 82400 (3%) ø 17544 (3%) ø
spike_lk_ticker_timeout ✔️ 83224 (3%) ø 17592 (3%) ø
spike_lk_update_process_app_base ✔️ 145204 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ 100968 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list
bootloader (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-ON/bootloader-map.txt	2022-03-15 11:36:18.267349308 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/bootloader-map.txt	2022-03-15 11:36:18.487352241 +0000
@@ -1,19 +1,20 @@
 | Module                 |           .text |       .data |          .bss |
 |------------------------|-----------------|-------------|---------------|
-| [fill]                 |       190(+190) |       7(+7) |       32(+32) |
+| [fill]                 |       172(+172) |       7(+7) |       32(+32) |
 | [lib]/CoreBattery.a    |       472(+472) |       0(+0) |         0(+0) |
+| [lib]/CoreSPI.a        |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/FileSystemKit.a  |       694(+694) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a       |     5898(+5898) |     16(+16) | 13816(+13816) |
 | [lib]/c.a              |   42360(+42360) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a            |     3276(+3276) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a |   72164(+72164) |   528(+528) | 10919(+10919) |
+| [lib]/mbed-os-static.a |   72306(+72306) |   528(+528) | 10919(+10919) |
 | [lib]/misc             |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |           0(+0) |       0(+0) |         0(+0) |
 | default_bd.cpp.obj     |       242(+242) |       0(+0) |     568(+568) |
-| main.cpp.obj           |       712(+712) |       1(+1) |     492(+492) |
+| main.cpp.obj           |     1648(+1648) |       1(+1) |     636(+636) |
 | signing_keys.c.obj     |           0(+0) |       0(+0) |         0(+0) |
-| Subtotals              | 126228(+126228) | 3128(+3128) | 25952(+25952) |
-Total Static RAM memory (data + bss): 29080(+29080) bytes
-Total Flash memory (text + data): 129356(+129356) bytes
+| Subtotals              | 127316(+127316) | 3128(+3128) | 26096(+26096) |
+Total Static RAM memory (data + bss): 29224(+29224) bytes
+Total Flash memory (text + data): 130444(+130444) bytes
 
Flash used: 140204 (6%) / total: 2097152
SRAM used: 29512 (5%) / total: 524288

@HPezz HPezz force-pushed the hugo/feature/Integrate-led-animation-in-bootloader branch from 32730d8 to 43daced Compare March 15, 2022 11:29
@ladislas ladislas merged commit fecb3a8 into develop Mar 15, 2022
@ladislas ladislas deleted the hugo/feature/Integrate-led-animation-in-bootloader branch March 15, 2022 11:31
@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants