🎨 (led animation): Stop() reset all member variables #578

HPezz · 2022-03-15T17:38:24Z

No description provided.

codecov · 2022-03-15T17:41:19Z

Codecov Report

Merging #578 (33ae19b) into develop (039a453) will not change coverage.
The diff coverage is n/a.

❗ Current head 33ae19b differs from pull request most recent head 5fce534. Consider uploading reports for the commit 5fce534 to get more accurate results

@@            Coverage Diff            @@
##           develop      #578   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          107       107           
  Lines         1698      1698           
=========================================
  Hits          1698      1698

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

github-actions · 2022-03-15T17:46:13Z

File comparision analysis report

🔖 Info

base: develop / 378acab + mbed-os-6.15.1+fixes + -std=c++20
head: hugo/feature/Upgrade-stop-funcs-in-led-animations / 378acab + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	140204 (53%)	121940 (46%)	29512 (5%)
os	222588 (14%)	1342084 (85%)	31144 (5%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	222588 (10%)	ø	31144 (5%)	ø
bootloader	✔️	✅	✅	140204 (6%)	ø	29512 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	258168 (12%)	ø	35272 (6%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	191600 (9%)	ø	30976 (5%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	165248 (7%)	ø	28680 (5%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	194032 (9%)	ø	30384 (5%)	ø
spike_lk_ble	✔️	✅	✅	183968 (8%)	ø	30376 (5%)	ø
spike_lk_bluetooth	✔️	✅	✅	91192 (4%)	ø	17472 (3%)	ø
spike_lk_cg_animations	✔️	✅	✅	149224 (7%)	ø	30416 (5%)	ø
spike_lk_color_kit	✔️	✅	✅	88800 (4%)	ø	19624 (3%)	ø
spike_lk_coreled	✔️	✅	✅	88556 (4%)	ø	19632 (3%)	ø
spike_lk_event_queue	✔️	✅	✅	84664 (4%)	ø	18136 (3%)	ø
spike_lk_file_reception	✔️	✅	✅	331612 (15%)	ø	33536 (6%)	ø
spike_lk_filesystem_kit	✔️	✅	✅	127740 (6%)	ø	20216 (3%)	ø
spike_lk_flash_memory	✔️	✅	✅	87352 (4%)	ø	17512 (3%)	ø
spike_lk_lcd	✔️	✅	✅	155544 (7%)	ø	30064 (5%)	ø
spike_lk_led	✔️	✅	✅	88808 (4%)	ø	19400 (3%)	ø
spike_lk_led_kit	✔️	❌	❌	109196 (5%) 109516 (5%)	📈 320 (0%)	20576 (3%)	ø
spike_lk_log_kit	✔️	✅	✅	92000 (4%)	ø	18168 (3%)	ø
spike_lk_motors	✔️	✅	✅	86576 (4%)	ø	17552 (3%)	ø
spike_lk_reinforcer	✔️	❌	❌	91872 (4%) 91808 (4%)	📉 -64 (0%)	20232 (3%)	ø
spike_lk_rfid	✔️	✅	✅	91008 (4%)	ø	17472 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	87600 (4%)	ø	18584 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	84584 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	85336 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90896 (4%)	ø	17496 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	92248 (4%)	ø	17632 (3%)	ø
spike_lk_serial_number	✔️	✅	✅	82400 (3%)	ø	17544 (3%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	83224 (3%)	ø	17592 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	145204 (6%)	ø	21352 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100968 (4%)	ø	18472 (3%)	ø
spike_lk_wifi	✔️	✅	✅	131280 (6%)	ø	20832 (3%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84688 (4%)	ø	18448 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	84000 (4%)	ø	17536 (3%)	ø

🗺️ Map files diff output

Click to show diff list

spike_lk_led_kit (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_led_kit-map.txt	2022-03-16 10:58:45.544660138 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_led_kit-map.txt	2022-03-16 10:58:45.756677616 +0000
@@ -1,20 +1,20 @@
 | Module                  |         .text |       .data |          .bss |
 |-------------------------|---------------|-------------|---------------|
-| [fill]                  |     206(+206) |       8(+8) |       32(+32) |
+| [fill]                  |     218(+218) |       8(+8) |       32(+32) |
 | [lib]/ColorKit.a        |     864(+864) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |       28(+28) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/LedKit.a          | 16574(+16574) |       0(+0) |         0(+0) |
+| [lib]/LedKit.a          | 16894(+16894) |       0(+0) |         0(+0) |
 | [lib]/c.a               | 26052(+26052) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a             |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |     564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 34292(+34292) |   444(+444) |   9990(+9990) |
 | [lib]/misc              |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |   5864(+5864) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   5834(+5834) |       0(+0) |   7200(+7200) |
-| Subtotals               | 97748(+97748) | 2936(+2936) | 17352(+17352) |
+| main.cpp.obj            |   5822(+5822) |       0(+0) |   7200(+7200) |
+| Subtotals               | 98068(+98068) | 2936(+2936) | 17352(+17352) |
 Total Static RAM memory (data + bss): 20288(+20288) bytes
-Total Flash memory (text + data): 100684(+100684) bytes
+Total Flash memory (text + data): 101004(+101004) bytes

Flash used: 109516&nbsp;(5%) / total: 2097152
SRAM used: 20576&nbsp;(3%) / total: 524288

spike_lk_reinforcer (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_reinforcer-map.txt	2022-03-16 10:58:46.980787822 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_reinforcer-map.txt	2022-03-16 10:58:47.196807846 +0000
@@ -1,20 +1,20 @@
 | Module                  |         .text |       .data |          .bss |
 |-------------------------|---------------|-------------|---------------|
-| [fill]                  |     196(+196) |       8(+8) |       32(+32) |
+| [fill]                  |     144(+144) |       8(+8) |       32(+32) |
 | [lib]/ColorKit.a        |     864(+864) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |       28(+28) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/LedKit.a          |   1900(+1900) |       0(+0) |         0(+0) |
+| [lib]/LedKit.a          |   1888(+1888) |       0(+0) |         0(+0) |
 | [lib]/c.a               | 26112(+26112) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a             |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |     564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 34292(+34292) |   444(+444) |   9990(+9990) |
 | [lib]/misc              |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |   5424(+5424) |       8(+8) |       44(+44) |
 | main.cpp.obj            |   4514(+4514) |       0(+0) |   6856(+6856) |
-| Subtotals               | 81364(+81364) | 2936(+2936) | 17008(+17008) |
+| Subtotals               | 81300(+81300) | 2936(+2936) | 17008(+17008) |
 Total Static RAM memory (data + bss): 19944(+19944) bytes
-Total Flash memory (text + data): 84300(+84300) bytes
+Total Flash memory (text + data): 84236(+84236) bytes

Flash used: 91808&nbsp;(4%) / total: 2097152
SRAM used: 20232&nbsp;(3%) / total: 524288

github-actions · 2022-03-15T17:47:34Z

File comparision analysis report

🔖 Info

base: develop / 378acab + mbed-os-6.15.1+fixes + -std=c++20
head: hugo/feature/Upgrade-stop-funcs-in-led-animations / 378acab + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	140204 (53%)	121940 (46%)	29512 (5%)
os	213080 (13%)	1351592 (86%)	25136 (4%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	213080 (10%)	ø	25136 (4%)	ø
bootloader	✔️	✅	✅	140204 (6%)	ø	29512 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	250624 (11%)	ø	29240 (5%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	174568 (8%)	ø	24952 (4%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	148840 (7%)	ø	22528 (4%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	177960 (8%)	ø	24360 (4%)	ø
spike_lk_ble	✔️	✅	✅	174508 (8%)	ø	24360 (4%)	ø
spike_lk_bluetooth	✔️	✅	✅	73256 (3%)	ø	11448 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	141016 (6%)	ø	24416 (4%)	ø
spike_lk_color_kit	✔️	✅	✅	65584 (3%)	ø	13624 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76164 (3%)	ø	13688 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74736 (3%)	ø	12072 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	326904 (15%)	ø	27576 (5%)	ø
spike_lk_filesystem_kit	✔️	✅	✅	103540 (4%)	ø	14048 (2%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_lcd	✔️	✅	✅	142584 (6%)	ø	23992 (4%)	ø
spike_lk_led	✔️	✅	✅	65744 (3%)	ø	13392 (2%)	ø
spike_lk_led_kit	✔️	❌	❌	101132 (4%) 101516 (4%)	📈 384 (0%)	14640 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	68528 (3%)	ø	11912 (2%)	ø
spike_lk_motors	✔️	✅	✅	62528 (2%)	ø	11488 (2%)	ø
spike_lk_reinforcer	✔️	❌	❌	73032 (3%) 72968 (3%)	📉 -64 (0%)	14240 (2%)	ø
spike_lk_rfid	✔️	✅	✅	73072 (3%)	ø	11448 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	78196 (3%)	ø	12568 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	66968 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_serial_number	✔️	✅	✅	58560 (2%)	ø	11424 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	122724 (5%)	ø	15288 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

spike_lk_led_kit (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_led_kit-map.txt	2022-03-16 10:58:34.886805486 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_led_kit-map.txt	2022-03-16 10:58:35.082807348 +0000
@@ -1,19 +1,19 @@
 | Module                 |         .text |       .data |          .bss |
 |------------------------|---------------|-------------|---------------|
-| [fill]                 |     156(+156) |       8(+8) |       28(+28) |
+| [fill]                 |     228(+228) |       8(+8) |       28(+28) |
 | [lib]/ColorKit.a       |     864(+864) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a        |       28(+28) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a     |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/LedKit.a         | 16574(+16574) |       0(+0) |         0(+0) |
+| [lib]/LedKit.a         | 16894(+16894) |       0(+0) |         0(+0) |
 | [lib]/c.a              | 26028(+26028) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a            |   7084(+7084) |       0(+0) |         0(+0) |
 | [lib]/m.a              |     204(+204) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a | 30752(+30752) |   444(+444) |   9954(+9954) |
 | [lib]/misc             |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |   5356(+5356) |       8(+8) |       44(+44) |
-| main.cpp.obj           |   3844(+3844) |       0(+0) |   1304(+1304) |
-| Subtotals              | 91204(+91204) | 2936(+2936) | 11416(+11416) |
+| main.cpp.obj           |   3836(+3836) |       0(+0) |   1304(+1304) |
+| Subtotals              | 91588(+91588) | 2936(+2936) | 11416(+11416) |
 Total Static RAM memory (data + bss): 14352(+14352) bytes
-Total Flash memory (text + data): 94140(+94140) bytes
+Total Flash memory (text + data): 94524(+94524) bytes

Flash used: 101516&nbsp;(4%) / total: 2097152
SRAM used: 14640&nbsp;(2%) / total: 524288

spike_lk_reinforcer (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_reinforcer-map.txt	2022-03-16 10:58:36.046810414 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_reinforcer-map.txt	2022-03-16 10:58:36.218810896 +0000
@@ -1,19 +1,19 @@
 | Module                 |         .text |       .data |          .bss |
 |------------------------|---------------|-------------|---------------|
-| [fill]                 |     190(+190) |       8(+8) |       24(+24) |
+| [fill]                 |     134(+134) |       8(+8) |       24(+24) |
 | [lib]/ColorKit.a       |     864(+864) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a        |       28(+28) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a     |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/LedKit.a         |   1900(+1900) |       0(+0) |         0(+0) |
+| [lib]/LedKit.a         |   1888(+1888) |       0(+0) |         0(+0) |
 | [lib]/c.a              | 25356(+25356) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a            |   3276(+3276) |       0(+0) |         0(+0) |
 | [lib]/m.a              |     204(+204) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a | 30728(+30728) |   444(+444) |   9954(+9954) |
 | [lib]/misc             |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |         0(+0) |       0(+0) |         0(+0) |
-| main.cpp.obj           |   2548(+2548) |       0(+0) |     960(+960) |
-| Subtotals              | 65408(+65408) | 2928(+2928) | 11024(+11024) |
+| main.cpp.obj           |   2552(+2552) |       0(+0) |     960(+960) |
+| Subtotals              | 65344(+65344) | 2928(+2928) | 11024(+11024) |
 Total Static RAM memory (data + bss): 13952(+13952) bytes
-Total Flash memory (text + data): 68336(+68336) bytes
+Total Flash memory (text + data): 68272(+68272) bytes

Flash used: 72968&nbsp;(3%) / total: 2097152
SRAM used: 14240&nbsp;(2%) / total: 524288

sonarcloud · 2022-03-16T11:01:18Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
21 Code Smells

No Coverage information
4.4% Duplication

HPezz force-pushed the hugo/feature/Upgrade-stop-funcs-in-led-animations branch 3 times, most recently from 547aad2 to c8d080b Compare March 16, 2022 08:46

ladislas force-pushed the hugo/feature/Upgrade-stop-funcs-in-led-animations branch from 33ae19b to 752ae14 Compare March 16, 2022 10:51

HPezz added 2 commits March 16, 2022 11:51

🎨 (led animation): Stop() reset all member variables

e826927

🩹 (led animation): Start all animations at stage 0

5fce534

ladislas force-pushed the hugo/feature/Upgrade-stop-funcs-in-led-animations branch from 752ae14 to 5fce534 Compare March 16, 2022 10:52

ladislas merged commit 378acab into develop Mar 16, 2022

ladislas deleted the hugo/feature/Upgrade-stop-funcs-in-led-animations branch March 16, 2022 10:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎨 (led animation): Stop() reset all member variables #578

🎨 (led animation): Stop() reset all member variables #578

HPezz commented Mar 15, 2022

codecov bot commented Mar 15, 2022 •

edited

Loading

github-actions bot commented Mar 15, 2022 •

edited

Loading

github-actions bot commented Mar 15, 2022 •

edited

Loading

sonarcloud bot commented Mar 16, 2022

🎨 (led animation): Stop() reset all member variables #578

🎨 (led animation): Stop() reset all member variables #578

Conversation

HPezz commented Mar 15, 2022

codecov bot commented Mar 15, 2022 • edited Loading

Codecov Report

github-actions bot commented Mar 15, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Mar 15, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

sonarcloud bot commented Mar 16, 2022

codecov bot commented Mar 15, 2022 •

edited

Loading

github-actions bot commented Mar 15, 2022 •

edited

Loading

github-actions bot commented Mar 15, 2022 •

edited

Loading