Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 (rc): Call process_event of State Machine in event queue #635

Conversation

ladislas
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #635 (b7ae80e) into develop (a1f9d8e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #635   +/-   ##
========================================
  Coverage    99.01%   99.01%           
========================================
  Files           89       89           
  Lines         1828     1830    +2     
========================================
+ Hits          1810     1812    +2     
  Misses          18       18           
Impacted Files Coverage Δ
libs/RobotKit/include/RobotController.h 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Mar 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 145300 (55%) 116844 (44%) 30048 (5%)
os 265060 (16%) 1299612 (83%) 34768 (6%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 265316 (12%)
265060 (12%)
📉
-256 (0%)
34768 (6%) ø
bootloader ✔️ 145300 (6%) ø 30048 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ 258168 (12%) ø 35272 (6%) ø
certs_emc_ble_led_motors ✔️ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 194032 (9%) ø 30384 (5%) ø
spike_lk_behavior_kit ✔️ 135460 (6%) ø 21416 (4%) ø
spike_lk_ble ✔️ 184512 (8%) ø 30752 (5%) ø
spike_lk_bluetooth ✔️ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ 149224 (7%) ø 30416 (5%) ø
spike_lk_color_kit ✔️ 88800 (4%) ø 19624 (3%) ø
spike_lk_coreled ✔️ 88556 (4%) ø 19632 (3%) ø
spike_lk_event_queue ✔️ 84664 (4%) ø 18136 (3%) ø
spike_lk_file_reception ✔️ 331612 (15%) ø 33536 (6%) ø
spike_lk_filesystem_kit ✔️ 127740 (6%) ø 20216 (3%) ø
spike_lk_flash_memory ✔️ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ 155544 (7%) ø 30064 (5%) ø
spike_lk_led ✔️ 88808 (4%) ø 19400 (3%) ø
spike_lk_led_kit ✔️ 96184 (4%) ø 20376 (3%) ø
spike_lk_log_kit ✔️ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ 86576 (4%) ø 17552 (3%) ø
spike_lk_reinforcer ✔️ 96248 (4%) ø 20376 (3%) ø
spike_lk_rfid ✔️ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ 87600 (4%) ø 18584 (3%) ø
spike_lk_sensors_light ✔️ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ 85336 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ 92248 (4%) ø 17632 (3%) ø
spike_lk_serial_number ✔️ 82752 (3%) ø 17648 (3%) ø
spike_lk_ticker_timeout ✔️ 83224 (3%) ø 17592 (3%) ø
spike_lk_update_process_app_base ✔️ 145204 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ 100968 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-03-25 13:22:45.862551553 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-03-25 13:22:46.214560330 +0000
@@ -1,35 +1,35 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       516(+516) |     13(+13) |       98(+98) |
+| [fill]                  |       468(+468) |     13(+13) |       98(+98) |
 | [lib]/BLEKit.a          |     1136(+1136) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a      |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a     |       460(+460) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a        |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a     |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a         |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a       |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a         |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a     |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileSystemKit.a   |       738(+738) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a          |     5542(+5542) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     1282(+1282) |     12(+12) |     132(+132) |
 | [lib]/c.a               |   42284(+42284) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 161408(+161408) |   769(+769) | 19647(+19647) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   11868(+11868) |   254(+254) | 10786(+10786) |
-| Subtotals               | 241896(+241896) | 3632(+3632) | 30832(+30832) |
+| main.cpp.obj            |   11660(+11660) |   254(+254) | 10786(+10786) |
+| Subtotals               | 241640(+241640) | 3632(+3632) | 30832(+30832) |
 Total Static RAM memory (data + bss): 34464(+34464) bytes
-Total Flash memory (text + data): 245528(+245528) bytes
+Total Flash memory (text + data): 245272(+245272) bytes
 
Flash used: 265060&nbsp;(12%) / total: 2097152
SRAM used: 34768&nbsp;(6%) / total: 524288

@github-actions
Copy link

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 145300 (55%) 116844 (44%) 30048 (5%)
os 255824 (16%) 1308848 (83%) 28752 (5%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 256080 (12%)
255824 (12%)
📉
-256 (0%)
28752 (5%) ø
bootloader ✔️ 145300 (6%) ø 30048 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ 250624 (11%) ø 29240 (5%) ø
certs_emc_ble_led_motors ✔️ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 177960 (8%) ø 24360 (4%) ø
spike_lk_behavior_kit ✔️ 117332 (5%) ø 15432 (2%) ø
spike_lk_ble ✔️ 174828 (8%) ø 24672 (4%) ø
spike_lk_bluetooth ✔️ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ 141016 (6%) ø 24416 (4%) ø
spike_lk_color_kit ✔️ 65584 (3%) ø 13624 (2%) ø
spike_lk_coreled ✔️ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_reception ✔️ 326904 (15%) ø 27576 (5%) ø
spike_lk_filesystem_kit ✔️ 103540 (4%) ø 14048 (2%) ø
spike_lk_flash_memory ✔️ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ 142584 (6%) ø 23992 (4%) ø
spike_lk_led ✔️ 65744 (3%) ø 13392 (2%) ø
spike_lk_led_kit ✔️ 77336 (3%) ø 14376 (2%) ø
spike_lk_log_kit ✔️ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ 62528 (2%) ø 11488 (2%) ø
spike_lk_reinforcer ✔️ 77400 (3%) ø 14376 (2%) ø
spike_lk_rfid ✔️ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ 58904 (2%) ø 11464 (2%) ø
spike_lk_ticker_timeout ✔️ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ 122724 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-03-25 13:22:49.646612096 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-03-25 13:22:49.994614323 +0000
@@ -1,34 +1,34 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       502(+502) |     13(+13) |       94(+94) |
+| [fill]                  |       454(+454) |     13(+13) |       94(+94) |
 | [lib]/BLEKit.a          |     1136(+1136) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a      |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a     |       460(+460) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a        |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a     |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a         |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a       |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a         |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a     |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/FileSystemKit.a   |       738(+738) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a          |     5542(+5542) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     1282(+1282) |     12(+12) |     132(+132) |
 | [lib]/c.a               |   42396(+42396) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 157884(+157884) |   769(+769) | 19611(+19611) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     4116(+4116) |       8(+8) |       28(+28) |
-| main.cpp.obj            |     9558(+9558) |   254(+254) |   4826(+4826) |
-| Subtotals               | 234520(+234520) | 3632(+3632) | 24816(+24816) |
+| main.cpp.obj            |     9350(+9350) |   254(+254) |   4826(+4826) |
+| Subtotals               | 234264(+234264) | 3632(+3632) | 24816(+24816) |
 Total Static RAM memory (data + bss): 28448(+28448) bytes
-Total Flash memory (text + data): 238152(+238152) bytes
+Total Flash memory (text + data): 237896(+237896) bytes
 
Flash used: 255824&nbsp;(12%) / total: 2097152
SRAM used: 28752&nbsp;(5%) / total: 524288

@ladislas ladislas merged commit 0caed51 into develop Mar 25, 2022
@ladislas ladislas deleted the ladislas/yann/feature/state-machine/call-raise-in-event-queue branch March 25, 2022 13:26
ladislas added a commit that referenced this pull request Apr 28, 2022
When sending reinforcer (or any timed command) while still sending
punctual commands resulted in deadlock because of ISR vs mutex lock
priority issues (similar to #635)

Solution was to add event queue in CommandKit to `execute` commands in a
differrent context

Co-Authored-By: Ladislas de Toldi <ladislas@detoldi.me>
ladislas added a commit that referenced this pull request May 4, 2022
When sending reinforcer (or any timed command) while still sending
punctual commands resulted in deadlock because of ISR vs mutex lock
priority issues (similar to #635)

Solution was to add event queue in CommandKit to `execute` commands in a
differrent context

Co-Authored-By: Ladislas de Toldi <ladislas@detoldi.me>
ladislas added a commit that referenced this pull request May 4, 2022
When sending reinforcer (or any timed command) while still sending
punctual commands resulted in deadlock because of ISR vs mutex lock
priority issues (similar to #635)

Solution was to add event queue in CommandKit to `execute` commands in a
differrent context

Co-Authored-By: Ladislas de Toldi <ladislas@detoldi.me>
ladislas added a commit that referenced this pull request May 9, 2022
When sending reinforcer (or any timed command) while still sending
punctual commands resulted in deadlock because of ISR vs mutex lock
priority issues (similar to #635)

Solution was to add event queue in CommandKit to `execute` commands in a
differrent context

Co-Authored-By: Ladislas de Toldi <ladislas@detoldi.me>
ladislas added a commit that referenced this pull request May 11, 2022
When sending reinforcer (or any timed command) while still sending
punctual commands resulted in deadlock because of ISR vs mutex lock
priority issues (similar to #635)

Solution was to add event queue in CommandKit to `execute` commands in a
differrent context

Co-Authored-By: Ladislas de Toldi <ladislas@detoldi.me>
ladislas added a commit that referenced this pull request May 11, 2022
When sending reinforcer (or any timed command) while still sending
punctual commands resulted in deadlock because of ISR vs mutex lock
priority issues (similar to #635)

Solution was to add event queue in CommandKit to `execute` commands in a
differrent context

Co-Authored-By: Ladislas de Toldi <ladislas@detoldi.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants