✨ (rc): Implement BLE Service File Reception #705

YannLocatelli · 2022-04-21T17:00:23Z

github-actions · 2022-04-21T17:12:49Z

File comparision analysis report

🔖 Info

base: develop / 5dffc74 + mbed-os-6.15.1+fixes + -std=c++20
head: yann/feature/robot-controller/add-ble-service-file-reception / 69baa23 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	145244 (55%)	116900 (44%)	30048 (5%)
os	307024 (19%)	1257648 (80%)	35640 (6%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	297908 (14%) 307024 (14%)	📈 9116 (3%)	33280 (6%) 35640 (6%)	📈 2360 (7%)
bootloader	✔️	✅	✅	145244 (6%)	ø	30048 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	250688 (11%)	ø	29240 (5%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	174568 (8%)	ø	24952 (4%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	148840 (7%)	ø	22528 (4%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	177960 (8%)	ø	24360 (4%)	ø
spike_lk_behavior_kit	✔️	✅	✅	142592 (6%)	ø	15704 (2%)	ø
spike_lk_ble	✔️	❌	❌	224928 (10%) 225056 (10%)	📈 128 (0%)	27760 (5%) 27776 (5%)	📈 16 (0%)
spike_lk_bluetooth	✔️	✅	✅	73256 (3%)	ø	11448 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	143960 (6%)	ø	46488 (8%)	ø
spike_lk_color_kit	✔️	✅	✅	65712 (3%)	ø	13744 (2%)	ø
spike_lk_command_kit	✔️	✅	✅	144856 (6%)	ø	16360 (3%)	ø
spike_lk_config_kit	✔️	✅	✅	124204 (5%)	ø	14312 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76164 (3%)	ø	13688 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74736 (3%)	ø	12072 (2%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	103604 (4%)	ø	14048 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	326984 (15%)	ø	27576 (5%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_lcd	✔️	✅	✅	146192 (6%)	ø	46072 (8%)	ø
spike_lk_led	✔️	✅	✅	65744 (3%)	ø	13392 (2%)	ø
spike_lk_led_kit	✔️	✅	✅	103220 (4%)	ø	14664 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	63736 (3%)	ø	12256 (2%)	ø
spike_lk_motors	✔️	✅	✅	62528 (2%)	ø	11488 (2%)	ø
spike_lk_reinforcer	✔️	✅	✅	101996 (4%)	ø	14664 (2%)	ø
spike_lk_rfid	✔️	✅	✅	73072 (3%)	ø	11448 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	78196 (3%)	ø	12568 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	66968 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_serial_number	✔️	✅	✅	58904 (2%)	ø	11464 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	122788 (5%)	ø	15288 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-04-22 20:04:47.384997283 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-04-22 20:04:47.689014149 +0000
@@ -1,39 +1,39 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       494(+494) |     13(+13) |     145(+145) |
+| [fill]                  |       490(+490) |     21(+21) |     145(+145) |
 | [lib]/BLEKit.a          |     1066(+1066) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a      |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a     |     1228(+1228) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a        |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a      |     1716(+1716) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a     |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a  |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a         |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a       |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a       |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a         |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a     |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
-| [lib]/FileManagerKit.a  |       812(+812) |       0(+0) |         0(+0) |
+| [lib]/FileManagerKit.a  |     1268(+1268) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a          |   19198(+19198) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/Utils.a           |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     1282(+1282) |     12(+12) |     132(+132) |
-| [lib]/c.a               |   42396(+42396) | 2572(+2572) |       97(+97) |
+| [lib]/c.a               |   43396(+43396) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 157712(+157712) |   769(+769) | 19611(+19611) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
-| [lib]/stdc++.a          |     5444(+5444) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   30942(+30942) |   510(+510) |   9031(+9031) |
-| Subtotals               | 273304(+273304) | 3888(+3888) | 29088(+29088) |
-Total Static RAM memory (data + bss): 32976(+32976) bytes
-Total Flash memory (text + data): 277192(+277192) bytes
+| [lib]/stdc++.a          |     9520(+9520) |     16(+16) |     204(+204) |
+| main.cpp.obj            |   31926(+31926) |   510(+510) | 11191(+11191) |
+| Subtotals               | 279816(+279816) | 3904(+3904) | 31408(+31408) |
+Total Static RAM memory (data + bss): 35312(+35312) bytes
+Total Flash memory (text + data): 283720(+283720) bytes

Flash used: 307024&nbsp;(14%) / total: 2097152
SRAM used: 35640&nbsp;(6%) / total: 524288

spike_lk_ble (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-04-22 20:04:51.173202221 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-04-22 20:04:51.417214864 +0000
@@ -1,18 +1,18 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       398(+398) |     17(+17) |       82(+82) |
+| [fill]                  |       378(+378) |     17(+17) |       82(+82) |
 | [lib]/BLEKit.a          |     1210(+1210) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       154(+154) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |     1312(+1312) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   41940(+41940) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7084(+7084) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 139100(+139100) |   705(+705) | 19323(+19323) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     9520(+9520) |     16(+16) |     204(+204) |
-| main.cpp.obj            |     3538(+3538) |     78(+78) |   4322(+4322) |
-| Subtotals               | 204484(+204484) | 3392(+3392) | 24056(+24056) |
-Total Static RAM memory (data + bss): 27448(+27448) bytes
-Total Flash memory (text + data): 207876(+207876) bytes
+| main.cpp.obj            |     3686(+3686) |     78(+78) |   4338(+4338) |
+| Subtotals               | 204612(+204612) | 3392(+3392) | 24072(+24072) |
+Total Static RAM memory (data + bss): 27464(+27464) bytes
+Total Flash memory (text + data): 208004(+208004) bytes

Flash used: 225056&nbsp;(10%) / total: 2097152
SRAM used: 27776&nbsp;(5%) / total: 524288

github-actions · 2022-04-21T17:14:01Z

File comparision analysis report

🔖 Info

base: develop / 5dffc74 + mbed-os-6.15.1+fixes + -std=c++20
head: yann/feature/robot-controller/add-ble-service-file-reception / 69baa23 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	145244 (55%)	116900 (44%)	30048 (5%)
os	327980 (20%)	1236692 (79%)	41848 (7%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	318800 (15%) 327980 (15%)	📈 9180 (2%)	39488 (7%) 41848 (7%)	📈 2360 (5%)
bootloader	✔️	✅	✅	145244 (6%)	ø	30048 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	258248 (12%)	ø	35272 (6%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	191600 (9%)	ø	30976 (5%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	165248 (7%)	ø	28680 (5%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	194032 (9%)	ø	30384 (5%)	ø
spike_lk_behavior_kit	✔️	✅	✅	151960 (7%)	ø	21648 (4%)	ø
spike_lk_ble	✔️	❌	❌	233436 (11%) 233420 (11%)	📉 -16 (0%)	33880 (6%) 33832 (6%)	📉 -48 (0%)
spike_lk_bluetooth	✔️	✅	✅	91192 (4%)	ø	17472 (3%)	ø
spike_lk_cg_animations	✔️	✅	✅	152232 (7%)	ø	52488 (10%)	ø
spike_lk_color_kit	✔️	✅	✅	88992 (4%)	ø	19744 (3%)	ø
spike_lk_command_kit	✔️	✅	✅	156752 (7%)	ø	22560 (4%)	ø
spike_lk_config_kit	✔️	✅	✅	136740 (6%)	ø	20368 (3%)	ø
spike_lk_coreled	✔️	✅	✅	88556 (4%)	ø	19632 (3%)	ø
spike_lk_event_queue	✔️	✅	✅	84664 (4%)	ø	18136 (3%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	127820 (6%)	ø	20216 (3%)	ø
spike_lk_file_reception	✔️	✅	✅	331692 (15%)	ø	33536 (6%)	ø
spike_lk_flash_memory	✔️	✅	✅	87352 (4%)	ø	17512 (3%)	ø
spike_lk_lcd	✔️	✅	✅	159200 (7%)	ø	52144 (9%)	ø
spike_lk_led	✔️	✅	✅	88808 (4%)	ø	19400 (3%)	ø
spike_lk_led_kit	✔️	✅	✅	115724 (5%)	ø	20608 (3%)	ø
spike_lk_log_kit	✔️	✅	✅	85016 (4%)	ø	18512 (3%)	ø
spike_lk_motors	✔️	✅	✅	86576 (4%)	ø	17552 (3%)	ø
spike_lk_reinforcer	✔️	✅	✅	111852 (5%)	ø	20608 (3%)	ø
spike_lk_rfid	✔️	✅	✅	91008 (4%)	ø	17472 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	87600 (4%)	ø	18584 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	84584 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	85336 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90896 (4%)	ø	17496 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	92248 (4%)	ø	17632 (3%)	ø
spike_lk_serial_number	✔️	✅	✅	82752 (3%)	ø	17648 (3%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	83224 (3%)	ø	17592 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	145268 (6%)	ø	21352 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100968 (4%)	ø	18472 (3%)	ø
spike_lk_wifi	✔️	✅	✅	131280 (6%)	ø	20832 (3%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84688 (4%)	ø	18448 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	84000 (4%)	ø	17536 (3%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-04-22 20:04:50.469374036 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-04-22 20:04:50.809378811 +0000
@@ -1,39 +1,39 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       476(+476) |     13(+13) |     157(+157) |
+| [fill]                  |       536(+536) |     21(+21) |     157(+157) |
 | [lib]/BLEKit.a          |     1066(+1066) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a      |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a     |     1228(+1228) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a        |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a      |     2216(+2216) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a     |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a  |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a         |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a       |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a       |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a         |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a     |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
-| [lib]/FileManagerKit.a  |       812(+812) |       0(+0) |         0(+0) |
+| [lib]/FileManagerKit.a  |     1268(+1268) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a          |   19198(+19198) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/Utils.a           |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     1282(+1282) |     12(+12) |     132(+132) |
-| [lib]/c.a               |   42284(+42284) | 2572(+2572) |       97(+97) |
+| [lib]/c.a               |   43284(+43284) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 161236(+161236) |   769(+769) | 19647(+19647) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
-| [lib]/stdc++.a          |     5864(+5864) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   45548(+45548) |   510(+510) | 15191(+15191) |
-| Subtotals               | 292584(+292584) | 3888(+3888) | 35296(+35296) |
-Total Static RAM memory (data + bss): 39184(+39184) bytes
-Total Flash memory (text + data): 296472(+296472) bytes
+| [lib]/stdc++.a          |     9940(+9940) |     16(+16) |     204(+204) |
+| main.cpp.obj            |   46532(+46532) |   510(+510) | 17351(+17351) |
+| Subtotals               | 299160(+299160) | 3904(+3904) | 37616(+37616) |
+Total Static RAM memory (data + bss): 41520(+41520) bytes
+Total Flash memory (text + data): 303064(+303064) bytes

Flash used: 327980&nbsp;(15%) / total: 2097152
SRAM used: 41848&nbsp;(7%) / total: 524288

spike_lk_ble (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-04-22 20:04:54.861435714 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-04-22 20:04:55.153439964 +0000
@@ -1,19 +1,19 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
 | [fill]                  |       392(+392) |     17(+17) |       78(+78) |
 | [lib]/BLEKit.a          |     1210(+1210) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       122(+122) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |     1312(+1312) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   41964(+41964) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 142640(+142640) |   705(+705) | 19359(+19359) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     9940(+9940) |     16(+16) |     204(+204) |
-| main.cpp.obj            |     6160(+6160) |     78(+78) | 10410(+10410) |
-| Subtotals               | 211476(+211476) | 3392(+3392) | 30176(+30176) |
-Total Static RAM memory (data + bss): 33568(+33568) bytes
+| main.cpp.obj            |     6160(+6160) |     78(+78) | 10362(+10362) |
+| Subtotals               | 211476(+211476) | 3392(+3392) | 30128(+30128) |
+Total Static RAM memory (data + bss): 33520(+33520) bytes
 Total Flash memory (text + data): 214868(+214868) bytes

Flash used: 233420&nbsp;(11%) / total: 2097152
SRAM used: 33832&nbsp;(6%) / total: 524288

codecov · 2022-04-22T16:17:48Z

Codecov Report

Merging #705 (69baa23) into develop (547f827) will decrease coverage by 0.06%.
The diff coverage is 84.61%.

❗ Current head 69baa23 differs from pull request most recent head dd2c5ce. Consider uploading reports for the commit dd2c5ce to get more accurate results

@@             Coverage Diff             @@
##           develop     #705      +/-   ##
===========================================
- Coverage    94.61%   94.54%   -0.07%     
===========================================
  Files          106      106              
  Lines         2265     2274       +9     
===========================================
+ Hits          2143     2150       +7     
- Misses         122      124       +2

Impacted Files	Coverage Δ
libs/FileManagerKit/include/FileReception.h	`100.00% <ø> (ø)`
libs/RobotKit/include/RobotController.h	`92.45% <50.00%> (-1.67%)`	⬇️
libs/BLEKit/include/BLEServiceFileReception.h	`100.00% <100.00%> (ø)`
libs/FileManagerKit/source/FileReception.cpp	`100.00% <100.00%> (ø)`

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

ladislas

LGTM 👍

rien à redire sauf un std::span 😂

libs/BLEKit/include/BLEServiceFileReception.h

ladislas

LGTM 👍

…ception - Explicit callback exist comparing it with nullptr - Remove reference to std::span

…:span<uint8_t/char>

sonarcloud · 2022-04-25T10:25:35Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

YannLocatelli requested a review from ladislas April 21, 2022 17:00

YannLocatelli self-assigned this Apr 21, 2022

YannLocatelli force-pushed the yann/feature/robot-controller/add-ble-service-file-reception branch from 28407d5 to 0a3b7da Compare April 22, 2022 16:14

YannLocatelli marked this pull request as ready for review April 22, 2022 16:26

ladislas approved these changes Apr 22, 2022

View reviewed changes

libs/BLEKit/include/BLEServiceFileReception.h Outdated Show resolved Hide resolved

ladislas added the 01 - type: task Something to do label Apr 22, 2022

ladislas added this to the v1.0.0 milestone Apr 22, 2022

YannLocatelli force-pushed the yann/feature/robot-controller/add-ble-service-file-reception branch from 0a3b7da to 69baa23 Compare April 22, 2022 19:53

ladislas approved these changes Apr 24, 2022

View reviewed changes

YannLocatelli added 3 commits April 25, 2022 12:15

🚸 (ble): Use callback instead of a get for path in BLE Service FileRe…

4248b88

…ception - Explicit callback exist comparing it with nullptr - Remove reference to std::span

✨ (rc): Add FileReception BLE Service

14d11df

♻️ (filereception): Use std::span<const uint8_t/char> instead of std:…

dd2c5ce

…:span<uint8_t/char>

ladislas force-pushed the yann/feature/robot-controller/add-ble-service-file-reception branch from 69baa23 to dd2c5ce Compare April 25, 2022 10:15

ladislas merged commit 0270b56 into develop Apr 25, 2022

ladislas deleted the yann/feature/robot-controller/add-ble-service-file-reception branch April 25, 2022 10:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ (rc): Implement BLE Service File Reception #705

✨ (rc): Implement BLE Service File Reception #705

YannLocatelli commented Apr 21, 2022 •

edited

Loading

github-actions bot commented Apr 21, 2022 •

edited

Loading

github-actions bot commented Apr 21, 2022 •

edited

Loading

codecov bot commented Apr 22, 2022 •

edited

Loading

ladislas left a comment

ladislas left a comment

sonarcloud bot commented Apr 25, 2022

✨ (rc): Implement BLE Service File Reception #705

✨ (rc): Implement BLE Service File Reception #705

Conversation

YannLocatelli commented Apr 21, 2022 • edited Loading

github-actions bot commented Apr 21, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Apr 21, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

codecov bot commented Apr 22, 2022 • edited Loading

Codecov Report

ladislas left a comment

Choose a reason for hiding this comment

ladislas left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Apr 25, 2022

YannLocatelli commented Apr 21, 2022 •

edited

Loading

github-actions bot commented Apr 21, 2022 •

edited

Loading

github-actions bot commented Apr 21, 2022 •

edited

Loading

codecov bot commented Apr 22, 2022 •

edited

Loading