-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ (rc): Re-enter Working state at Command Received event #850
Closed
YannLocatelli
wants to merge
2
commits into
develop
from
yann/refactor/rc/re-enter-working-state-at-command-received
Closed
♻️ (rc): Re-enter Working state at Command Received event #850
YannLocatelli
wants to merge
2
commits into
develop
from
yann/refactor/rc/re-enter-working-state-at-command-received
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #850 +/- ##
===========================================
+ Coverage 95.36% 95.43% +0.06%
===========================================
Files 115 115
Lines 2544 2539 -5
===========================================
- Hits 2426 2423 -3
+ Misses 118 116 -2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
Kudos, SonarCloud Quality Gate passed! |
Add a new transition in SM to stop and start timeout instead of doing them in callback. Fix issue to turn on screen after emergency stop
YannLocatelli
force-pushed
the
yann/refactor/rc/re-enter-working-state-at-command-received
branch
from
June 7, 2022 16:48
51d2ed4
to
9082736
Compare
This was referenced Jun 7, 2022
See #853 |
YannLocatelli
deleted the
yann/refactor/rc/re-enter-working-state-at-command-received
branch
June 10, 2022 15:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Turn on screen again when reinforcer is run after an emergency stop. Doing it by using start working behaviour that turn on screen automatically.
Inconvenient
Image of start working behaviour is displayed each time and shift the video animation from motors and leds, and stopped any other animation on any command received.
Solution
2 solutions are possible