Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚸 (reinforcers): Change reinforcers timing #868

Merged
merged 1 commit into from
Jun 14, 2022
Merged

🚸 (reinforcers): Change reinforcers timing #868

merged 1 commit into from
Jun 14, 2022

Conversation

HPezz
Copy link
Contributor

@HPezz HPezz commented Jun 10, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 10, 2022 •
edited
Loading

Codecov Report

Merging #868 (f75361d) into develop (6f3d312) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f75361d differs from pull request most recent head 0d1b035. Consider uploading reports for the commit 0d1b035 to get more accurate results

@@           Coverage Diff            @@
##           develop     #868   +/-   ##
========================================
  Coverage    95.36%   95.36%           
========================================
  Files          115      115           
  Lines         2568     2568           
========================================
  Hits          2449     2449           
  Misses         119      119
Impacted Files Coverage Δ
libs/BehaviorKit/source/BehaviorKit.cpp 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@HPezz HPezz linked an issue Jun 10, 2022 that may be closed by this pull request
BehaviorKit - Moving reinforcers spin too much #862
Closed
@github-actions
Copy link

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 167668 (63%) 94476 (36%) 30856 (5%)
os 397644 (25%) 1167028 (74%) 80776 (15%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ✅ 397644 (18%) ø 80776 (15%) ø
bootloader ✔️ ✅ ✅ 167668 (7%) ø 30856 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 257608 (12%) ø 35872 (6%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 190960 (9%) ø 31512 (6%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 164608 (7%) ø 29344 (5%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91304 (4%) ø 16264 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 193408 (9%) ø 30920 (5%) ø
spike_lk_behavior_kit ✔️ ❌ ✅ 196036 (9%) ø 54528 (10%) ø
spike_lk_ble ✔️ ✅ ✅ 233676 (11%) ø 34712 (6%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 90616 (4%) ø 18016 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 152200 (7%) ø 53064 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88352 (4%) ø 20216 (3%) ø
spike_lk_command_kit ✔️ ❌ ✅ 199956 (9%) ø 57856 (11%) ø
spike_lk_config_kit ✔️ ✅ ✅ 136100 (6%) ø 20976 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 87916 (4%) ø 20104 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84088 (4%) ø 18744 (3%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 143648 (6%) ø 21304 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331052 (15%) ø 34072 (6%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 86712 (4%) ø 18056 (3%) ø
spike_lk_lcd ✔️ ✅ ✅ 177100 (8%) ø 53992 (10%) ø
spike_lk_led ✔️ ✅ ✅ 88168 (4%) ø 19872 (3%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115708 (5%) ø 21024 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 84440 (4%) ø 19248 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86008 (4%) ø 18088 (3%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 112188 (5%) ø 21024 (4%) ø
spike_lk_rfid ✔️ ✅ ✅ 84512 (4%) ø 18032 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 86960 (4%) ø 19120 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 83944 (4%) ø 18056 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 84696 (4%) ø 18056 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90336 (4%) ø 18032 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 91608 (4%) ø 18296 (3%) ø
spike_lk_serial_number ✔️ ✅ ✅ 82176 (3%) ø 18320 (3%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 82584 (3%) ø 18072 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 144644 (6%) ø 21896 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100328 (4%) ø 19080 (3%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 88152 (4%) ø 20120 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 130640 (6%) ø 21368 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84112 (4%) ø 18920 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 83424 (3%) ø 18144 (3%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@github-actions
Copy link

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 168372 (64%) 93772 (35%) 30760 (5%)
os 363256 (23%) 1201416 (76%) 73720 (14%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ✅ 363256 (17%) ø 73720 (14%) ø
bootloader ✔️ ✅ ✅ 168372 (8%) ø 30760 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 250704 (11%) ø 29240 (5%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 174584 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 92008 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 177976 (8%) ø 24360 (4%) ø
spike_lk_behavior_kit ✔️ ❌ ✅ 187536 (8%) ø 48112 (9%) ø
spike_lk_ble ✔️ ✅ ✅ 225792 (10%) ø 28056 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 144632 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65712 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ ❌ ✅ 189760 (9%) ø 50928 (9%) ø
spike_lk_config_kit ✔️ ✅ ✅ 124204 (5%) ø 14312 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 128680 (6%) ø 14384 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 326984 (15%) ø 27576 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 167468 (7%) ø 47320 (9%) ø
spike_lk_led ✔️ ✅ ✅ 65744 (3%) ø 13392 (2%) ø
spike_lk_led_kit ✔️ ✅ ✅ 103992 (4%) ø 14608 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 63736 (3%) ø 12256 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62600 (2%) ø 11488 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 103480 (4%) ø 14608 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 78644 (3%) ø 11504 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 58904 (2%) ø 11464 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 122788 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 79964 (3%) ø 13296 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@ladislas ladislas added the 01 - type: task Something to do label Jun 13, 2022
@ladislas ladislas added this to the v1.0.0 milestone Jun 13, 2022
ladislas
ladislas requested changes Jun 13, 2022
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comment

libs/BehaviorKit/source/BehaviorKit.cpp
@@ -10,6 +10,8 @@ namespace leka {

using namespace std::chrono;

inline constexpr auto reinforcer_duration = 2700ms;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ici tu veux static parce que c'est juste pour cette TU.

Suggested change
inline constexpr auto reinforcer_duration = 2700ms;
static constexpr auto kReinforcerDuration = 2700ms;

@ladislas ladislas force-pushed the hugo/bugfix/Good-moving-reinforcers branch from f75361d to 0d1b035 Compare June 14, 2022 15:26
@ladislas ladislas merged commit 51ec038 into develop Jun 14, 2022
@ladislas ladislas deleted the hugo/bugfix/Good-moving-reinforcers branch June 14, 2022 15:26
@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas requested changes

@YannLocatelli YannLocatelli YannLocatelli approved these changes

Assignees

@HPezz HPezz

Labels
01 - type: task Something to do
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

BehaviorKit - Moving reinforcers spin too much
3 participants
@HPezz @ladislas @YannLocatelli