mmyster/feature/lk quad digital to analog converter #940

MMyster · 2022-07-19T11:13:29Z

✨ (interface): Add QDAC
✨ (drivers): Add CoreQDAC
🎨 (drivers): Update QDAC
🎨 (drivers): Update QDAC
🎨 (drivers): Update QDAC
✨ (spikes): Add lk_qdac

Need :

mmyster/feature/quad digital to analog converter #933

github-actions · 2022-07-19T11:28:08Z

File comparision analysis report

🔖 Info

base: mmyster/feature/quad-digital-to-analog-converter / 0933a53 + mbed-os-6.15.1+fixes + -std=c++20
head: mmyster/feature/lk-quad-digital-to-analog-converter / 0933a53 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	181260 (69%)	80884 (30%)	37456 (7%)
os	396956 (25%)	1167716 (74%)	80632 (15%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	396892 (18%) 396956 (18%)	📈 64 (0%)	80632 (15%)	ø
bootloader	✔️	✅	✅	181260 (8%)	ø	37456 (7%)	ø
spike_lk_audio	✔️	✅	✅	132380 (6%)	ø	20984 (4%)	ø
spike_lk_behavior_kit	✔️	✅	✅	196052 (9%)	ø	54528 (10%)	ø
spike_lk_ble	✔️	✅	✅	233676 (11%)	ø	34712 (6%)	ø
spike_lk_bluetooth	✔️	✅	✅	92236 (4%)	ø	18064 (3%)	ø
spike_lk_cg_animations	✔️	✅	✅	152200 (7%)	ø	53064 (10%)	ø
spike_lk_color_kit	✔️	✅	✅	88352 (4%)	ø	20216 (3%)	ø
spike_lk_command_kit	✔️	✅	✅	199956 (9%)	ø	57856 (11%)	ø
spike_lk_config_kit	✔️	✅	✅	136100 (6%)	ø	20976 (4%)	ø
spike_lk_coreled	✔️	✅	✅	87916 (4%)	ø	20104 (3%)	ø
spike_lk_event_queue	✔️	✅	✅	84088 (4%)	ø	18744 (3%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	143648 (6%)	ø	21304 (4%)	ø
spike_lk_file_reception	✔️	✅	✅	331036 (15%)	ø	34072 (6%)	ø
spike_lk_flash_memory	✔️	✅	✅	86712 (4%)	ø	18056 (3%)	ø
spike_lk_fs	✔️	✅	✅	171024 (8%)	ø	47968 (9%)	ø
spike_lk_lcd	✔️	✅	✅	177100 (8%)	ø	53992 (10%)	ø
spike_lk_led_kit	✔️	✅	✅	115708 (5%)	ø	21024 (4%)	ø
spike_lk_log_kit	✔️	✅	✅	84440 (4%)	ø	19248 (3%)	ø
spike_lk_motors	✔️	✅	✅	86008 (4%)	ø	18088 (3%)	ø
spike_lk_qdac	✨	-	-	91508 (4%)	-	18616 (3%)	-
spike_lk_reinforcer	✔️	✅	✅	112188 (5%)	ø	21024 (4%)	ø
spike_lk_rfid	✔️	✅	✅	84636 (4%)	ø	18016 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	87056 (4%)	ø	19120 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	83944 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	84696 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90336 (4%)	ø	18032 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	91608 (4%)	ø	18296 (3%)	ø
spike_lk_serial_number	✔️	✅	✅	82176 (3%)	ø	18336 (3%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	82584 (3%)	ø	18072 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	144644 (6%)	ø	21896 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100328 (4%)	ø	19080 (3%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	87940 (4%)	ø	19952 (3%)	ø
spike_lk_wifi	✔️	✅	✅	130640 (6%)	ø	21368 (4%)	ø
spike_mbed_blinky	✔️	✅	✅	57616 (2%)	ø	11496 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84112 (4%)	ø	18920 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	83424 (3%)	ø	18144 (3%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-08-19 19:33:01.828528711 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-08-19 19:33:02.252548304 +0000
@@ -1,46 +1,46 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       530(+530) |     22(+22) |     213(+213) |
+| [fill]                     |       574(+574) |     22(+22) |     213(+213) |
 | [lib]/BLEKit.a             |     1292(+1292) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
-| [lib]/BehaviorKit.a        |     2314(+2314) |       0(+0) |         0(+0) |
+| [lib]/BehaviorKit.a        |     2334(+2334) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7920(+7920) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1308(+1308) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1018(+1018) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       232(+232) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       638(+638) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   42180(+42180) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 172108(+172108) |   769(+769) | 19735(+19735) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10732(+10732) |     16(+16) |     204(+204) |
 | main.cpp.obj               |   81390(+81390) |   548(+548) | 25105(+25105) |
-| Subtotals                  | 356696(+356696) | 3944(+3944) | 76360(+76360) |
+| Subtotals                  | 356760(+356760) | 3944(+3944) | 76360(+76360) |
 Total Static RAM memory (data + bss): 80304(+80304) bytes
-Total Flash memory (text + data): 360640(+360640) bytes
+Total Flash memory (text + data): 360704(+360704) bytes

Flash used: 396956&nbsp;(18%) / total: 2097152
SRAM used: 80632&nbsp;(15%) / total: 524288

spike_lk_qdac (click to expand)

Flash used: 91508&nbsp;(4%) / total: 2097152
SRAM used: 18616&nbsp;(3%) / total: 524288

github-actions · 2022-07-19T11:28:25Z

File comparision analysis report

🔖 Info

base: mmyster/feature/quad-digital-to-analog-converter / 0933a53 + mbed-os-6.15.1+fixes + -std=c++20
head: mmyster/feature/lk-quad-digital-to-analog-converter / 0933a53 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	168820 (64%)	93324 (35%)	30920 (5%)
os	363496 (23%)	1201176 (76%)	73704 (14%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	363496 (17%)	ø	73704 (14%)	ø
bootloader	✔️	✅	✅	168820 (8%)	ø	30920 (5%)	ø
spike_lk_audio	✔️	✅	✅	122324 (5%)	ø	14568 (2%)	ø
spike_lk_behavior_kit	✔️	✅	✅	187568 (8%)	ø	48112 (9%)	ø
spike_lk_ble	✔️	✅	✅	225792 (10%)	ø	28056 (5%)	ø
spike_lk_bluetooth	✔️	✅	✅	82948 (3%)	ø	11544 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	144632 (6%)	ø	46528 (8%)	ø
spike_lk_color_kit	✔️	✅	✅	65712 (3%)	ø	13744 (2%)	ø
spike_lk_command_kit	✔️	✅	✅	189760 (9%)	ø	50928 (9%)	ø
spike_lk_config_kit	✔️	✅	✅	124188 (5%)	ø	14312 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76164 (3%)	ø	13688 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74736 (3%)	ø	12072 (2%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	128680 (6%)	ø	14384 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	326968 (15%)	ø	27576 (5%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_fs	✔️	✅	✅	171728 (8%)	ø	47880 (9%)	ø
spike_lk_lcd	✔️	✅	✅	167468 (7%)	ø	47320 (9%)	ø
spike_lk_led_kit	✔️	✅	✅	103992 (4%)	ø	14608 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	63736 (3%)	ø	12256 (2%)	ø
spike_lk_motors	✔️	✅	✅	62600 (2%)	ø	11488 (2%)	ø
spike_lk_qdac	✨	-	-	78564 (3%)	-	11816 (2%)	-
spike_lk_reinforcer	✔️	✅	✅	103480 (4%)	ø	14608 (2%)	ø
spike_lk_rfid	✔️	✅	✅	80856 (3%)	ø	11512 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	78196 (3%)	ø	12568 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	67048 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_serial_number	✔️	✅	✅	58904 (2%)	ø	11480 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	122804 (5%)	ø	15288 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	81968 (3%)	ø	13280 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-08-19 19:31:33.364059198 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-08-19 19:31:33.804058079 +0000
@@ -1,46 +1,46 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       548(+548) |     22(+22) |     192(+192) |
+| [fill]                     |       528(+528) |     22(+22) |     192(+192) |
 | [lib]/BLEKit.a             |     1292(+1292) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
-| [lib]/BehaviorKit.a        |     2314(+2314) |       0(+0) |         0(+0) |
+| [lib]/BehaviorKit.a        |     2334(+2334) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7920(+7920) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1308(+1308) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1018(+1018) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       232(+232) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       638(+638) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   43396(+43396) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 170856(+170856) |   769(+769) | 19647(+19647) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10312(+10312) |     16(+16) |     204(+204) |
 | main.cpp.obj               |   50300(+50300) |   548(+548) | 18286(+18286) |
 | Subtotals                  | 324808(+324808) | 3944(+3944) | 69432(+69432) |
 Total Static RAM memory (data + bss): 73376(+73376) bytes
 Total Flash memory (text + data): 328752(+328752) bytes

spike_lk_qdac (click to expand)

Flash used: 78564&nbsp;(3%) / total: 2097152
SRAM used: 11816&nbsp;(2%) / total: 524288

codecov · 2022-07-20T11:10:51Z

Codecov Report

❗ No coverage uploaded for pull request base (mmyster/feature/quad-digital-to-analog-converter@0933a53). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4ba2fee differs from pull request most recent head a2cbd0b. Consider uploading reports for the commit a2cbd0b to get more accurate results

@@                                 Coverage Diff                                 @@
##             mmyster/feature/quad-digital-to-analog-converter     #940   +/-   ##
===================================================================================
  Coverage                                                    ?   95.91%           
===================================================================================
  Files                                                       ?      125           
  Lines                                                       ?     2936           
  Branches                                                    ?        0           
===================================================================================
  Hits                                                        ?     2816           
  Misses                                                      ?      120           
  Partials                                                    ?        0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

YannLocatelli

Quelques requêtes pour la clarté et un résultat un peu étonnant à expliquer.

Sinon tout est très bien en guise de spike pour montrer comment ça s'utilise, c'est bien 👍

spikes/lk_qdac/main.cpp

YannLocatelli · 2022-07-20T13:20:10Z

spikes/lk_qdac/main.cpp

+
+	log_info("Init !\n\n");
+	dac.init();
+	dac.writeAllChannels(0x0000, true);


Autre détails marquant avec cette ligne, c'est qu'on inscrit 0x0000 pour chaque channel et que après on obtient

000:00:01.002 [INFO] [main.cpp:32] printInputRegistersAndMemory > ================= Channel 0 ================= 000:00:01.005 [INFO] [main.cpp:34] printInputRegistersAndMemory > Input Registers === Data: 0 000:00:01.007 [INFO] [main.cpp:36] printInputRegistersAndMemory > EEPROM Memory ===== Data: fff 000:00:01.007 [INFO] [main.cpp:32] printInputRegistersAndMemory > ================= Channel 1 ================= 000:00:01.010 [INFO] [main.cpp:34] printInputRegistersAndMemory > Input Registers === Data: 0 000:00:01.013 [INFO] [main.cpp:36] printInputRegistersAndMemory > EEPROM Memory ===== Data: fff 000:00:01.013 [INFO] [main.cpp:32] printInputRegistersAndMemory > ================= Channel 2 ================= 000:00:01.016 [INFO] [main.cpp:34] printInputRegistersAndMemory > Input Registers === Data: 0 000:00:01.019 [INFO] [main.cpp:36] printInputRegistersAndMemory > EEPROM Memory ===== Data: fff 000:00:01.019 [INFO] [main.cpp:32] printInputRegistersAndMemory > ================= Channel 3 ================= 000:00:01.022 [INFO] [main.cpp:34] printInputRegistersAndMemory > Input Registers === Data: 0 000:00:01.025 [INFO] [main.cpp:36] printInputRegistersAndMemory > EEPROM Memory ===== Data: fff

Pourquoi fff pour la mémoire et pas 0 comme pour l'input registers?

spikes/lk_qdac/main.cpp

YannLocatelli · 2022-07-21T07:53:25Z

spikes/lk_qdac/main.cpp

+//
+
+auto corei2c = CoreI2C {PinName::SENSOR_PROXIMITY_MUX_I2C_SDA, PinName::SENSOR_PROXIMITY_MUX_I2C_SCL};
+auto dac	 = CoreQDACMCP4728 {corei2c, 0xC0};


Même résultat pour l'autre DAC avec l'adresse 0xC2?

YannLocatelli

Reste à corriger les 2 code smells et c'est bon pour moi 👌

ladislas

LGTM 👍

sonarcloud · 2022-08-19T19:30:19Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

MMyster marked this pull request as draft July 19, 2022 11:13

MMyster changed the base branch from develop to mmyster/feature/quad-digital-to-analog-converter July 19, 2022 12:53

MMyster force-pushed the mmyster/feature/quad-digital-to-analog-converter branch 2 times, most recently from 00972cd to e6ca578 Compare July 19, 2022 13:33

MMyster force-pushed the mmyster/feature/lk-quad-digital-to-analog-converter branch from 8094d0c to 2f45bae Compare July 20, 2022 10:59

MMyster force-pushed the mmyster/feature/lk-quad-digital-to-analog-converter branch from 2f45bae to a5c68f8 Compare July 20, 2022 11:14

MMyster marked this pull request as ready for review July 20, 2022 13:03

YannLocatelli requested changes Jul 20, 2022

View reviewed changes

MMyster force-pushed the mmyster/feature/lk-quad-digital-to-analog-converter branch 2 times, most recently from 1b571cf to 19f5ca8 Compare July 20, 2022 13:55

YannLocatelli reviewed Jul 21, 2022

View reviewed changes

YannLocatelli approved these changes Jul 21, 2022

View reviewed changes

MMyster force-pushed the mmyster/feature/lk-quad-digital-to-analog-converter branch from 19f5ca8 to 0b2a233 Compare July 21, 2022 14:00

MMyster force-pushed the mmyster/feature/quad-digital-to-analog-converter branch from e6ca578 to ed3cfbb Compare July 21, 2022 14:42

MMyster force-pushed the mmyster/feature/quad-digital-to-analog-converter branch from ed3cfbb to c8e19a2 Compare August 1, 2022 14:46

ladislas approved these changes Aug 18, 2022

View reviewed changes

MMyster force-pushed the mmyster/feature/quad-digital-to-analog-converter branch from aff29a3 to eb90226 Compare August 18, 2022 15:11

MMyster force-pushed the mmyster/feature/lk-quad-digital-to-analog-converter branch from 0b2a233 to 0b9fdc6 Compare August 18, 2022 15:56

MMyster force-pushed the mmyster/feature/quad-digital-to-analog-converter branch from adfa308 to cfeffdf Compare August 18, 2022 16:06

ladislas force-pushed the mmyster/feature/quad-digital-to-analog-converter branch from cfeffdf to 0109d91 Compare August 18, 2022 16:13

MMyster force-pushed the mmyster/feature/lk-quad-digital-to-analog-converter branch from 0b9fdc6 to d95b276 Compare August 18, 2022 16:16

ladislas force-pushed the mmyster/feature/quad-digital-to-analog-converter branch from 0109d91 to 0933a53 Compare August 18, 2022 16:16

MMyster force-pushed the mmyster/feature/lk-quad-digital-to-analog-converter branch from d95b276 to 430ae56 Compare August 18, 2022 16:22

✨ (spikes): Add lk_qdac spike

a2cbd0b

ladislas force-pushed the mmyster/feature/lk-quad-digital-to-analog-converter branch from 430ae56 to a2cbd0b Compare August 19, 2022 19:19

ladislas changed the base branch from mmyster/feature/quad-digital-to-analog-converter to develop August 19, 2022 19:20

ladislas merged commit 0179d07 into develop Aug 19, 2022

ladislas deleted the mmyster/feature/lk-quad-digital-to-analog-converter branch August 19, 2022 19:21

ladislas assigned MMyster Aug 19, 2022

ladislas added the 01 - type: task Something to do label Aug 19, 2022

ladislas added this to the Next Release milestone Aug 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mmyster/feature/lk quad digital to analog converter #940

mmyster/feature/lk quad digital to analog converter #940

MMyster commented Jul 19, 2022 •

edited

Loading

github-actions bot commented Jul 19, 2022 •

edited

Loading

github-actions bot commented Jul 19, 2022 •

edited

Loading

codecov bot commented Jul 20, 2022 •

edited

Loading

YannLocatelli left a comment

YannLocatelli Jul 20, 2022

YannLocatelli Jul 21, 2022

YannLocatelli left a comment

ladislas left a comment

sonarcloud bot commented Aug 19, 2022

mmyster/feature/lk quad digital to analog converter #940

mmyster/feature/lk quad digital to analog converter #940

Conversation

MMyster commented Jul 19, 2022 • edited Loading

github-actions bot commented Jul 19, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Jul 19, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

codecov bot commented Jul 20, 2022 • edited Loading

Codecov Report

YannLocatelli left a comment

Choose a reason for hiding this comment

YannLocatelli Jul 20, 2022

Choose a reason for hiding this comment

YannLocatelli Jul 21, 2022

Choose a reason for hiding this comment

YannLocatelli left a comment

Choose a reason for hiding this comment

ladislas left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Aug 19, 2022

MMyster commented Jul 19, 2022 •

edited

Loading

github-actions bot commented Jul 19, 2022 •

edited

Loading

github-actions bot commented Jul 19, 2022 •

edited

Loading

codecov bot commented Jul 20, 2022 •

edited

Loading