🩹 (serialnumber): Set date_of_test in Serial Number + ♻️ refactor #946

YannLocatelli · 2022-07-21T14:54:24Z

Validated on robot

Need

🔧 (serialnumber): Add /fs/sys/date_of_test #945

github-actions · 2022-07-21T15:09:01Z

File comparision analysis report

🔖 Info

base: develop / acc530d + mbed-os-6.15.1+fixes + -std=c++20
head: yann/feature/set-complete-serial-number / e1562ff + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	169508 (64%)	92636 (35%)	30920 (5%)
os	374592 (23%)	1190080 (76%)	74448 (14%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	374448 (17%) 374592 (17%)	📈 144 (0%)	74448 (14%)	ø
bootloader	✔️	✅	✅	169508 (8%)	ø	30920 (5%)	ø
spike_lk_audio	✔️	✅	✅	122324 (5%)	ø	14568 (2%)	ø
spike_lk_behavior_kit	✔️	✅	✅	186992 (8%)	ø	48112 (9%)	ø
spike_lk_ble	✔️	✅	✅	225792 (10%)	ø	28056 (5%)	ø
spike_lk_bluetooth	✔️	✅	✅	82948 (3%)	ø	11544 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	144632 (6%)	ø	46528 (8%)	ø
spike_lk_color_kit	✔️	✅	✅	65712 (3%)	ø	13744 (2%)	ø
spike_lk_command_kit	✔️	✅	✅	189760 (9%)	ø	50936 (9%)	ø
spike_lk_config_kit	✔️	✅	✅	124188 (5%)	ø	14312 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76164 (3%)	ø	13688 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74736 (3%)	ø	12072 (2%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	128680 (6%)	ø	14384 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	326968 (15%)	ø	27576 (5%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_fs	✔️	✅	✅	171856 (8%)	ø	47880 (9%)	ø
spike_lk_lcd	✔️	✅	✅	159468 (7%)	ø	46616 (8%)	ø
spike_lk_led_kit	✔️	✅	✅	103992 (4%)	ø	14608 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	63736 (3%)	ø	12256 (2%)	ø
spike_lk_motors	✔️	✅	✅	62600 (2%)	ø	11488 (2%)	ø
spike_lk_qdac	✔️	✅	✅	78564 (3%)	ø	11816 (2%)	ø
spike_lk_reinforcer	✔️	✅	✅	103480 (4%)	ø	14608 (2%)	ø
spike_lk_rfid	✔️	✅	✅	80920 (3%)	ø	11520 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	78196 (3%)	ø	12568 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	67048 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_serial_number	✔️	❌	❌	58904 (2%) 103876 (4%)	📈 44972 (76%)	11480 (2%) 14056 (2%)	📈 2576 (22%)
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	123476 (5%)	ø	15296 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	82032 (3%)	ø	13288 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-09-16 17:07:39.099634809 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-09-16 17:07:39.475642124 +0000
@@ -1,48 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       592(+592) |     22(+22) |     203(+203) |
+| [fill]                     |       556(+556) |     22(+22) |     203(+203) |
 | [lib]/ActivityKit.a        |       782(+782) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1292(+1292) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1854(+1854) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7944(+7944) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1308(+1308) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       750(+750) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1062(+1062) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1470(+1470) |       0(+0) |         0(+0) |
-| [lib]/SerialNumberKit.a    |       232(+232) |       0(+0) |         0(+0) |
+| [lib]/SerialNumberKit.a    |       380(+380) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       774(+774) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   43284(+43284) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 170856(+170856) |   769(+769) | 19647(+19647) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10684(+10684) |     16(+16) |     204(+204) |
-| main.cpp.obj               |   56422(+56422) |   548(+548) | 19011(+19011) |
-| Subtotals                  | 334168(+334168) | 3944(+3944) | 70176(+70176) |
+| main.cpp.obj               |   56438(+56438) |   548(+548) | 19011(+19011) |
+| Subtotals                  | 334296(+334296) | 3944(+3944) | 70176(+70176) |
 Total Static RAM memory (data + bss): 74120(+74120) bytes
-Total Flash memory (text + data): 338112(+338112) bytes
+Total Flash memory (text + data): 338240(+338240) bytes

Flash used: 374592&nbsp;(17%) / total: 2097152
SRAM used: 74448&nbsp;(14%) / total: 524288

spike_lk_serial_number (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_serial_number-map.txt	2022-09-16 17:07:51.659845524 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_serial_number-map.txt	2022-09-16 17:07:51.839848251 +0000
@@ -1,16 +1,17 @@
-| Module                  |         .text |       .data |        .bss |
-|-------------------------|---------------|-------------|-------------|
-| [fill]                  |       96(+96) |       8(+8) |     16(+16) |
-| [lib]/CoreMCU.a         |       16(+16) |       0(+0) |       0(+0) |
-| [lib]/HelloWorld.a      |       94(+94) |       0(+0) |       0(+0) |
-| [lib]/SerialNumberKit.a |     124(+124) |       0(+0) |       0(+0) |
-| [lib]/c.a               | 25432(+25432) | 2472(+2472) |     58(+58) |
-| [lib]/gcc.a             |   3116(+3116) |       0(+0) |       0(+0) |
-| [lib]/mbed-os-static.a  | 23342(+23342) |   444(+444) | 8098(+8098) |
-| [lib]/misc              |     188(+188) |       4(+4) |     28(+28) |
-| [lib]/nosys.a           |       32(+32) |       0(+0) |       0(+0) |
-| main.cpp.obj            |     264(+264) |       8(+8) |     56(+56) |
-| Subtotals               | 52704(+52704) | 2936(+2936) | 8256(+8256) |
-Total Static RAM memory (data + bss): 11192(+11192) bytes
-Total Flash memory (text + data): 55640(+55640) bytes
+| Module                  |         .text |       .data |          .bss |
+|-------------------------|---------------|-------------|---------------|
+| [fill]                  |     144(+144) |       4(+4) |       38(+38) |
+| [lib]/CoreMCU.a         |       16(+16) |       0(+0) |         0(+0) |
+| [lib]/FileManagerKit.a  |     812(+812) |       0(+0) |         0(+0) |
+| [lib]/HelloWorld.a      |       94(+94) |       0(+0) |         0(+0) |
+| [lib]/SerialNumberKit.a |     380(+380) |       0(+0) |         0(+0) |
+| [lib]/c.a               | 41076(+41076) | 2572(+2572) |       97(+97) |
+| [lib]/gcc.a             |   3276(+3276) |       0(+0) |         0(+0) |
+| [lib]/mbed-os-static.a  | 47390(+47390) |   460(+460) | 10193(+10193) |
+| [lib]/misc              |     188(+188) |       4(+4) |       28(+28) |
+| [lib]/nosys.a           |       32(+32) |       0(+0) |         0(+0) |
+| main.cpp.obj            |     432(+432) |       8(+8) |     364(+364) |
+| Subtotals               | 93840(+93840) | 3048(+3048) | 10720(+10720) |
+Total Static RAM memory (data + bss): 13768(+13768) bytes
+Total Flash memory (text + data): 96888(+96888) bytes

Flash used: 103876&nbsp;(4%) / total: 2097152
SRAM used: 14056&nbsp;(2%) / total: 524288

github-actions · 2022-07-21T15:10:29Z

File comparision analysis report

🔖 Info

base: develop / acc530d + mbed-os-6.15.1+fixes + -std=c++20
head: yann/feature/set-complete-serial-number / e1562ff + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	181884 (69%)	80260 (30%)	37456 (7%)
os	412684 (26%)	1151988 (73%)	81376 (15%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	412540 (19%) 412684 (19%)	📈 144 (0%)	81376 (15%)	ø
bootloader	✔️	✅	✅	181884 (8%)	ø	37456 (7%)	ø
spike_lk_audio	✔️	✅	✅	132380 (6%)	ø	20984 (4%)	ø
spike_lk_behavior_kit	✔️	✅	✅	195476 (9%)	ø	54528 (10%)	ø
spike_lk_ble	✔️	✅	✅	233676 (11%)	ø	34712 (6%)	ø
spike_lk_bluetooth	✔️	✅	✅	92236 (4%)	ø	18064 (3%)	ø
spike_lk_cg_animations	✔️	✅	✅	152264 (7%)	ø	53064 (10%)	ø
spike_lk_color_kit	✔️	✅	✅	88352 (4%)	ø	20216 (3%)	ø
spike_lk_command_kit	✔️	✅	✅	200020 (9%)	ø	57864 (11%)	ø
spike_lk_config_kit	✔️	✅	✅	136100 (6%)	ø	20976 (4%)	ø
spike_lk_coreled	✔️	✅	✅	87916 (4%)	ø	20104 (3%)	ø
spike_lk_event_queue	✔️	✅	✅	84088 (4%)	ø	18744 (3%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	143648 (6%)	ø	21304 (4%)	ø
spike_lk_file_reception	✔️	✅	✅	331036 (15%)	ø	34072 (6%)	ø
spike_lk_flash_memory	✔️	✅	✅	86712 (4%)	ø	18056 (3%)	ø
spike_lk_fs	✔️	✅	✅	171216 (8%)	ø	47968 (9%)	ø
spike_lk_lcd	✔️	✅	✅	169100 (8%)	ø	53288 (10%)	ø
spike_lk_led_kit	✔️	✅	✅	115708 (5%)	ø	21024 (4%)	ø
spike_lk_log_kit	✔️	✅	✅	84440 (4%)	ø	19248 (3%)	ø
spike_lk_motors	✔️	✅	✅	86008 (4%)	ø	18088 (3%)	ø
spike_lk_qdac	✔️	✅	✅	91508 (4%)	ø	18616 (3%)	ø
spike_lk_reinforcer	✔️	✅	✅	112188 (5%)	ø	21024 (4%)	ø
spike_lk_rfid	✔️	✅	✅	84636 (4%)	ø	18024 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	87056 (4%)	ø	19120 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	83944 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	84696 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90336 (4%)	ø	18032 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	91608 (4%)	ø	18296 (3%)	ø
spike_lk_serial_number	✔️	❌	❌	82176 (3%) 125820 (5%)	📈 43644 (53%)	18336 (3%) 20896 (3%)	📈 2560 (13%)
spike_lk_ticker_timeout	✔️	✅	✅	82584 (3%)	ø	18072 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	145284 (6%)	ø	21904 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100328 (4%)	ø	19080 (3%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	87940 (4%)	ø	19960 (3%)	ø
spike_lk_wifi	✔️	✅	✅	130640 (6%)	ø	21368 (4%)	ø
spike_mbed_blinky	✔️	✅	✅	57616 (2%)	ø	11496 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84112 (4%)	ø	18920 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	83424 (3%)	ø	18144 (3%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-09-16 17:08:16.944988919 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-09-16 17:08:17.360999549 +0000
@@ -1,48 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       578(+578) |     22(+22) |     224(+224) |
+| [fill]                     |       534(+534) |     22(+22) |     224(+224) |
 | [lib]/ActivityKit.a        |       782(+782) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1292(+1292) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1854(+1854) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7944(+7944) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1308(+1308) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       750(+750) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1062(+1062) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1470(+1470) |       0(+0) |         0(+0) |
-| [lib]/SerialNumberKit.a    |       232(+232) |       0(+0) |         0(+0) |
+| [lib]/SerialNumberKit.a    |       380(+380) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       774(+774) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   42180(+42180) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 172108(+172108) |   769(+769) | 19735(+19735) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10732(+10732) |     16(+16) |     204(+204) |
-| main.cpp.obj               |   93872(+93872) |   548(+548) | 25830(+25830) |
-| Subtotals                  | 371800(+371800) | 3944(+3944) | 77104(+77104) |
+| main.cpp.obj               |   93896(+93896) |   548(+548) | 25830(+25830) |
+| Subtotals                  | 371928(+371928) | 3944(+3944) | 77104(+77104) |
 Total Static RAM memory (data + bss): 81048(+81048) bytes
-Total Flash memory (text + data): 375744(+375744) bytes
+Total Flash memory (text + data): 375872(+375872) bytes

Flash used: 412684&nbsp;(19%) / total: 2097152
SRAM used: 81376&nbsp;(15%) / total: 524288

spike_lk_serial_number (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_serial_number-map.txt	2022-09-16 17:08:31.597349434 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_serial_number-map.txt	2022-09-16 17:08:31.817354099 +0000
@@ -1,19 +1,20 @@
-| Module                  |         .text |       .data |          .bss |
-|-------------------------|---------------|-------------|---------------|
-| [fill]                  |     148(+148) |       8(+8) |       28(+28) |
-| [lib]/CoreMCU.a         |       16(+16) |       0(+0) |         0(+0) |
-| [lib]/CriticalSection.a |         8(+8) |       0(+0) |         0(+0) |
-| [lib]/HelloWorld.a      |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/SerialNumberKit.a |     124(+124) |       0(+0) |         0(+0) |
-| [lib]/c.a               | 24948(+24948) | 2472(+2472) |       58(+58) |
-| [lib]/gcc.a             |   7148(+7148) |       0(+0) |         0(+0) |
-| [lib]/m.a               |     360(+360) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a  | 31638(+31638) |   444(+444) |   8226(+8226) |
-| [lib]/misc              |     188(+188) |       4(+4) |       28(+28) |
-| [lib]/nosys.a           |       32(+32) |       0(+0) |         0(+0) |
-| [lib]/stdc++.a          |   5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   2788(+2788) |       8(+8) |   6720(+6720) |
-| Subtotals               | 72916(+72916) | 2944(+2944) | 15104(+15104) |
-Total Static RAM memory (data + bss): 18048(+18048) bytes
-Total Flash memory (text + data): 75860(+75860) bytes
+| Module                  |           .text |       .data |          .bss |
+|-------------------------|-----------------|-------------|---------------|
+| [fill]                  |       180(+180) |       4(+4) |       38(+38) |
+| [lib]/CoreMCU.a         |         16(+16) |       0(+0) |         0(+0) |
+| [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
+| [lib]/FileManagerKit.a  |       812(+812) |       0(+0) |         0(+0) |
+| [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
+| [lib]/SerialNumberKit.a |       380(+380) |       0(+0) |         0(+0) |
+| [lib]/c.a               |   39860(+39860) | 2572(+2572) |       97(+97) |
+| [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
+| [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
+| [lib]/mbed-os-static.a  |   55210(+55210) |   460(+460) | 10317(+10317) |
+| [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
+| [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
+| [lib]/stdc++.a          |     5424(+5424) |       8(+8) |       44(+44) |
+| main.cpp.obj            |     3028(+3028) |       8(+8) |   7028(+7028) |
+| Subtotals               | 112740(+112740) | 3056(+3056) | 17552(+17552) |
+Total Static RAM memory (data + bss): 20608(+20608) bytes
+Total Flash memory (text + data): 115796(+115796) bytes

Flash used: 125820&nbsp;(5%) / total: 2097152
SRAM used: 20896&nbsp;(3%) / total: 524288

codecov · 2022-07-21T15:42:44Z

Codecov Report

Merging #946 (e1562ff) into develop (acc530d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #946      +/-   ##
===========================================
+ Coverage    96.01%   96.03%   +0.02%     
===========================================
  Files          131      133       +2     
  Lines         3085     3106      +21     
===========================================
+ Hits          2962     2983      +21     
  Misses         123      123

Impacted Files	Coverage Δ
libs/RobotKit/include/RobotController.h	`94.50% <100.00%> (ø)`
...ibs/SerialNumberKit/include/SerialNumberFormater.h	`100.00% <100.00%> (ø)`
libs/SerialNumberKit/include/SerialNumberKit.h	`100.00% <100.00%> (ø)`
...bs/SerialNumberKit/source/SerialNumberFormater.cpp	`100.00% <100.00%> (ø)`
libs/SerialNumberKit/source/SerialNumberKit.cpp	`100.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

HPezz

Good to me, modulo le path de date_of_test dans ta fonction setDateOfTest

libs/SerialNumberKit/include/SerialNumberKit.h

libs/SerialNumberKit/tests/SerialNumberKit_test.cpp

libs/SerialNumberKit/source/SerialNumberKit.cpp

sonarcloud · 2022-07-27T10:30:09Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

97.0% Coverage
0.0% Duplication

ladislas

quick first review of the PR :)
LGTM otherwise 👍

libs/SerialNumberKit/include/SerialNumberKit.h

libs/SerialNumberKit/source/SerialNumberKit.cpp

libs/SerialNumberKit/include/SerialNumberKit.h

ladislas

LGTM 👍

…mberFormater - Remove extra '-' - Return std::span instead of std::array - Print short serial number in spike

sonarcloud · 2022-09-16T17:09:01Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

YannLocatelli added the 01 - type: task Something to do label Jul 21, 2022

YannLocatelli added this to the Next Release milestone Jul 21, 2022

YannLocatelli requested review from ladislas and HPezz July 21, 2022 14:54

YannLocatelli self-assigned this Jul 21, 2022

YannLocatelli force-pushed the yann/feature/set-complete-serial-number branch 2 times, most recently from b41150a to 163d7c6 Compare July 21, 2022 15:34

YannLocatelli force-pushed the yann/feature/set-complete-serial-number branch 2 times, most recently from 5dac949 to 5db1ea4 Compare July 22, 2022 10:07

YannLocatelli linked an issue Jul 22, 2022 that may be closed by this pull request

Monitoring - Complete Serial Number with date_of_test #897

Closed

YannLocatelli marked this pull request as ready for review July 22, 2022 10:21

HPezz reviewed Jul 25, 2022

View reviewed changes

libs/SerialNumberKit/include/SerialNumberKit.h Outdated Show resolved Hide resolved

libs/SerialNumberKit/tests/SerialNumberKit_test.cpp Outdated Show resolved Hide resolved

YannLocatelli force-pushed the yann/feature/set-complete-serial-number branch from 1d63858 to 7bc6138 Compare July 27, 2022 10:20

YannLocatelli commented Jul 27, 2022

View reviewed changes

libs/SerialNumberKit/source/SerialNumberKit.cpp Outdated Show resolved Hide resolved

ladislas force-pushed the yann/feature/set-complete-serial-number branch from 7bc6138 to e1e510d Compare September 8, 2022 13:50

YannLocatelli force-pushed the yann/feature/set-complete-serial-number branch from e1e510d to b58e5db Compare September 12, 2022 16:43

ladislas requested changes Sep 13, 2022

View reviewed changes

YannLocatelli force-pushed the yann/feature/set-complete-serial-number branch 4 times, most recently from 843a8dc to bc89dcc Compare September 16, 2022 10:48

YannLocatelli mentioned this pull request Sep 16, 2022

🧱 (serialnumber): Handle epoch format for date_of_test #1026

Merged

4 tasks

ladislas approved these changes Sep 16, 2022

View reviewed changes

YannLocatelli added 2 commits September 16, 2022 18:58

♻️ (serialnumber): Dispatch serial number construction using SerialNu…

24dc8c3

…mberFormater - Remove extra '-' - Return std::span instead of std::array - Print short serial number in spike

🩹 (serialnumber): Set date_of_test in Serial Number

e1562ff

YannLocatelli force-pushed the yann/feature/set-complete-serial-number branch from bc89dcc to e1562ff Compare September 16, 2022 17:00

ladislas merged commit fb30049 into develop Sep 18, 2022

ladislas deleted the yann/feature/set-complete-serial-number branch September 18, 2022 21:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🩹 (serialnumber): Set date_of_test in Serial Number + ♻️ refactor #946

🩹 (serialnumber): Set date_of_test in Serial Number + ♻️ refactor #946

YannLocatelli commented Jul 21, 2022 •

edited by ladislas

Loading

github-actions bot commented Jul 21, 2022 •

edited

Loading

github-actions bot commented Jul 21, 2022 •

edited

Loading

codecov bot commented Jul 21, 2022 •

edited

Loading

HPezz left a comment

sonarcloud bot commented Jul 27, 2022

ladislas left a comment

ladislas left a comment

sonarcloud bot commented Sep 16, 2022 •

edited

Loading

🩹 (serialnumber): Set date_of_test in Serial Number + ♻️ refactor #946

🩹 (serialnumber): Set date_of_test in Serial Number + ♻️ refactor #946

Conversation

YannLocatelli commented Jul 21, 2022 • edited by ladislas Loading

github-actions bot commented Jul 21, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Jul 21, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

codecov bot commented Jul 21, 2022 • edited Loading

Codecov Report

HPezz left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jul 27, 2022

ladislas left a comment

Choose a reason for hiding this comment

ladislas left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Sep 16, 2022 • edited Loading

YannLocatelli commented Jul 21, 2022 •

edited by ladislas

Loading

github-actions bot commented Jul 21, 2022 •

edited

Loading

github-actions bot commented Jul 21, 2022 •

edited

Loading

codecov bot commented Jul 21, 2022 •

edited

Loading

sonarcloud bot commented Sep 16, 2022 •

edited

Loading