-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option --remove_pg_catalog_from_functions #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new option removes the pg_catalog schema before function calls. These may occur when PG replaces the desired function with an adequate other function.
Unfortunately position('a', 'b') is not directly callable. The reason is the parameters flipped compared to position('b' in 'a'). Possible is position('b' in 'a') pg_catalog.position('a', 'b') strpos('a', 'b') pg_catalog.strpos('a', 'b')
lelit
reviewed
Sep 13, 2021
lelit
reviewed
Sep 13, 2021
Rename option to remove-pg_catalog-from-functions and move it closer to other named options
lelit
reviewed
Sep 14, 2021
Codecov Report
@@ Coverage Diff @@
## v3 #90 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 23 23
Lines 6344 6351 +7
=======================================
+ Hits 6313 6320 +7
Misses 31 31
Continue to review full report at Codecov.
|
No functional change
Thank you Boris, this is now merged into v3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new option removes the pg_catalog schema before function calls.
These may occur when PG replaces the desired function with an
adequate other function.