Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation error #5

Open
neomafo88 opened this issue Aug 18, 2022 · 3 comments · May be fixed by #6
Open

Compilation error #5

neomafo88 opened this issue Aug 18, 2022 · 3 comments · May be fixed by #6

Comments

@neomafo88
Copy link

neomafo88 commented Aug 18, 2022 •
edited
Loading 

./chrome-session-dump.go:512:22: newline in string
./chrome-session-dump.go:512:22: syntax error: unexpected newline in argument list; possibly missing comma or )
./chrome-session-dump.go:513:29: syntax error: unexpected ] at end of statement
./chrome-session-dump.go:513:62: invalid character U+005C '\'
./chrome-session-dump.go:513:68: newline in string

fix: replace double-quotes " by backticks `
https://github.com/lemnos/chrome-session-dump/blob/master/chrome-session-dump.go#L512-L513

fmt.Printf(`Usage:
  -session-dump [options] ([session file] | [chrome dir])`)
aspiers pushed a commit to aspiers/chrome-session-dump that referenced this issue Nov 6, 2022
fix compilation error with literal newline (lemnos#5)
62db4c2 
Literal newlines need to be inside backticks not double quotes.

Fixes lemnos#5.
@aspiers aspiers linked a pull request Nov 6, 2022 that will close this issue
Open
@kucharskim
Copy link

Would it be possible to merge pull request #6 by @aspiers which fixes this problem?

@jbwells
Copy link

jbwells commented Jul 7, 2024

actually, the correct fix is to replace the newline and the following tabs and spaces by the text “chrome” (not including the quote marks). you can see the erroneous edit happened as part of commit 1a41842 on 2021-12-21.

aspiers pushed a commit to aspiers/chrome-session-dump that referenced this issue Sep 1, 2024
fix compilation error with literal newline (lemnos#5)
fedf227 
Literal newlines need to be inside backticks not double quotes.

Fixes lemnos#5.
@aspiers
Copy link

aspiers commented Sep 1, 2024

Good catch; updated the PR accordingly. Not sure why I didn't spot that myself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix compilation error with literal newline (#5) aspiers/chrome-session-dump
4 participants
@aspiers @kucharskim @jbwells @neomafo88