Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed similar next entry #63

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Allowed similar next entry #63

merged 4 commits into from
Jan 16, 2023

Conversation

lemredd
Copy link
Owner

@lemredd lemredd commented Jan 16, 2023

Changes

See resolved issues.
Additionally, made lastPassedEntry (previously rightEntry) manually set. It used to be a computed value

Resolved issues

Pull Requests to merge first

  • none

Breaking Changes

  • none

Pull Request Quality

  • Will have additional commits?
    • None
    • Yes
    • Yes, unless all tests are success
    • None, unless some tests are failing

Lacking Mechanism

Proof of Passing

Component Helpers Unit Tests
Component Unit Tests
Component Integration Tests

@lemredd
test(intg): ensure an edge case in computation
aaf962c 
The edge case bug occurs when entry to append is equal to previous entry
@lemredd
fix(intg): account mustClearEntryOnNextAppend
1bb41ec 
This fixes the edge case mentioned in aaf962c

fix #60
@lemredd
Merge branch 'master' into allowed_similar_next_entry
ca03111
@lemredd
fix(intg): set lastPassedEntry manually
8b50c60 
- `lastPassedEntry was previously `rightEntry`
- `lastPassedEntry` used to be a `computed` value
@lemredd lemredd self-assigned this Jan 16, 2023
@lemredd lemredd merged commit 5bc73e0 into master Jan 16, 2023
@lemredd lemredd deleted the allowed_similar_next_entry branch January 16, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lemredd lemredd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entering a number similar to previousResult does not complete the expression
1 participant
@lemredd