Fixed repo_token being displayed in clear text #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amercier
added a commit
to oeco-architectes/oeco-ruby
that referenced
this pull request
Jan 21, 2015
| @@ -63,9 +63,9 @@ def self.hash_to_file(hash) | |||
|
|
|||
| def self.apified_hash hash | |||
| config = Coveralls::Configuration.configuration | |||
| if ENV['CI'] || ENV['COVERALLS_DEBUG'] || Coveralls.testing | |||
There was a problem hiding this comment.
Hey why did you remove the ENV['CI'] from this conditional?
There was a problem hiding this comment.
Ooops, my bad. That was for testing and I left it accidentally in the commit. Hold on, I'm going to remove it.
|
@nickmerwin Fixed :) |
|
@nickmerwin What do you think about this? Do you think that can be merged? |
|
hi @amercier ah yes, thank you for pinging. I'll include in the next release (should be today). |
|
👍 |
nickmerwin
added a commit
that referenced
this pull request
Feb 3, 2015
Fixed repo_token being displayed in clear text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spaces after columns can be missing the JSON output. Because of that,
repo_tokenvalue is not replaced by[secure]. See https://travis-ci.org/amercier/oeco/builds/47742447 as an example.