Added pause & reset function. Also added a little help text. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also added code for a progress bar, but not finished yet, so commented that out.
added button active state
…ters/Figma-Timer into pie-chart-visualization
lennet
reviewed
Apr 25, 2020
lennet
reviewed
Apr 25, 2020
lennet
reviewed
Apr 25, 2020
lennet
reviewed
Apr 25, 2020
lennet
reviewed
Apr 25, 2020
lennet
reviewed
Apr 25, 2020
|
Thanks for your contribution, I like the new feature! I left you some comments. Overall it would be nice if you could:
|
Co-Authored-By: Leo Thomas <lennet@users.noreply.github.com>
This was referenced Apr 26, 2020
Co-Authored-By: Leo Thomas <lennet@users.noreply.github.com>
Co-Authored-By: Leo Thomas <lennet@users.noreply.github.com>
3 tasks
lennet
reviewed
Apr 28, 2020
lennet
reviewed
Apr 28, 2020
code.ts
Outdated
| if (reset) { | ||
| secondsToGo = seconds; | ||
| newText = fillUpTimeStringWithTemplate(secondsToInterval(secondsToGo), template); | ||
| newText = "Timer: " + newText; |
There was a problem hiding this comment.
Not all Timer start with "Timer: "
lennet
reviewed
Apr 28, 2020
also removed an unnecessary delay(), and fixed the 'timer:' bug
This was
linked to
issues
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lennet hope this is the right way to do it. Also not sure how 'good' the code is, but it works for me without ever crashing 🤞