-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: skippable read hooks #467
Conversation
This pull request has been linked to 1 task:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
7d21d16
to
97bcd04
Compare
97bcd04
to
937cb99
Compare
data: undefined, | ||
error: undefined, | ||
loading: false, | ||
} as SkippableReadResult<A, Profile, NotFoundError | UnspecifiedError>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the need for as ReturnType
but I didn't figure out how to do it better. Any ideas?
937cb99
to
d523f9e
Compare
d523f9e
to
1e2441f
Compare
parked till lens v2 react hooks |
type-safe skippable hooks (one for read results and one for paginated read results).
I'm not happy with the solution but also don't know any better one.