Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skippable read hooks #467

Closed
wants to merge 1 commit into from
Closed

feat: skippable read hooks #467

wants to merge 1 commit into from

Conversation

krzysu
Copy link
Contributor

@krzysu krzysu commented Aug 2, 2023

type-safe skippable hooks (one for read results and one for paginated read results).
I'm not happy with the solution but also don't know any better one.

@height
Copy link

height bot commented Aug 2, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-13464" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ✅ Ready (Inspect) Visit Preview Aug 10, 2023 11:46am

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

⚠️ No Changeset found

Latest commit: 1e2441f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@krzysu krzysu changed the title feat: skippable read hooks WIP feat: skippable read hooks Aug 2, 2023
@krzysu krzysu requested a review from cesarenaldi August 2, 2023 16:21
data: undefined,
error: undefined,
loading: false,
} as SkippableReadResult<A, Profile, NotFoundError | UnspecifiedError>;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the need for as ReturnType but I didn't figure out how to do it better. Any ideas?

@krzysu
Copy link
Contributor Author

krzysu commented Aug 16, 2023

parked till lens v2 react hooks

@krzysu krzysu closed this Aug 16, 2023
@krzysu krzysu deleted the T-13464/skippable-hooks branch September 27, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant