Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace support-page extension with a link to the documentation support page #1469

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Replace support-page extension with a link to the documentation support page #1469

merged 1 commit into from
Nov 23, 2020

Conversation

jakolehm
Copy link
Contributor

No description provided.

@jakolehm
remove support-page extension
c1d1b72 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm added the enhancement New feature or request label Nov 20, 2020
@jakolehm jakolehm added this to the 4.0.0 milestone Nov 20, 2020
jim-docker
jim-docker reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@jim-docker jim-docker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want it on the status bar too? Personally, I don't think it needs to be there but it was there in the extension.

@jakolehm
Copy link
Contributor Author

Do we want it on the status bar too? Personally, I don't think it needs to be there but it was there in the extension.

Nope, not needed.

@jakolehm
Copy link
Contributor Author

Related PR #1473

miskun
miskun approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@miskun miskun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nevalla
nevalla approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm merged commit 2f17a7e into master Nov 23, 2020
@jakolehm jakolehm deleted the remove-support-page-extension branch November 23, 2020 11:01
@jakolehm jakolehm mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-docker jim-docker jim-docker left review comments

@nevalla nevalla nevalla approved these changes

@miskun miskun miskun approved these changes

@leenamba leenamba Awaiting requested review from leenamba

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jakolehm @nevalla @miskun @jim-docker