Watch for added/removed local extensions #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
panuhorsmalahti
commented
Nov 23, 2020
•
panuhorsmalahti
commented
- If extension is copied to the extensions folder, it's dependencies are installed and it's loaded to the application. It's not enabled by default, however
- If the extensions is added from the UI, we need to later implement automatic enabling for it
- Extensions removal is also detected, but not completely implemented.
- Extension classes were slightly refactored to have less responsibilities
- Using chokidar to watch as it should be better than fs.watch
- Tested on macOS only for now
- Fixes Lens should notice added/removed extension folders #1461
jakolehm
approved these changes
Nov 23, 2020
| windowManager = WindowManager.getInstance<WindowManager>(proxyPort); | ||
| extensionLoader.initExtensions(await extensionManager.load()); // call after windowManager to see splash earlier | ||
|
|
||
| // call after windowManager to see splash earlier |
There was a problem hiding this comment.
This reminded me that maybe we should keep splash visible until all extensions are loaded. Story for another PR.
jakolehm
added
area/extension
5 tasks
Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
panuhorsmalahti
force-pushed
the
feature/extension-watcher
branch
from
5a93703
to
7bba783
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.