Fix events list default sort column #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Nokel81
approved these changes
Feb 12, 2021
jim-docker
approved these changes
Feb 12, 2021
ixrock
reviewed
Feb 12, 2021
| @@ -108,7 +108,7 @@ export class Events extends React.Component<Props> { | |||
| { title: "Involved Object", className: "object", sortBy: columnId.object, id: columnId.object }, | |||
| { title: "Source", className: "source", id: columnId.source }, | |||
| { title: "Count", className: "count", sortBy: columnId.count, id: columnId.count }, | |||
| { title: "Age", className: "age", sortBy: columnId.age, id: columnId.age }, | |||
| { title: "Last Seen", className: "age", sortBy: columnId.age, id: columnId.age }, | |||
There was a problem hiding this comment.
Line:81 might be broken since creationTimestamp returns a iso-date string, not timestamp (number)
[columnId.age]: (event: KubeEvent) => event.metadata.creationTimestamp,
|
Noticed weird inconsistency when sorted by Column Column |
|
Other thing it seems that sorting at
Expected behaviour (fixed in #2141) |
|
@ixrock good findings but those are out of scope for this PR. Let's open separate issues if needed. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal fix/alternative for #2141 .