Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supply github workflow for generating openlens release files. #5772

Closed
wants to merge 1 commit into from
Closed

supply github workflow for generating openlens release files. #5772

wants to merge 1 commit into from

Conversation

PhilippKuntschik
Copy link

The workflows contain the ideas of @ykursadkaya and @MuhammedKalkan. I also peeked at the existing workflows publish-master-npm and publish-release-npm

what does this PR do?

  • checkout
  • build packages for windows, mac and ubuntu
  • calculate SHA256
  • push to /releases subsite
  • if type: release: update /releases/latest

what does this PR not do?

  • it does no code signing since this is an open source and not proprietary software
  • it doesn't do any tests since this does not affect the source code.
  • it does not include any additional code or proprietary plugins
  • it does not introduce an EULA that is not part of this repo.

what does this solve?

  • the mess created with issue Unable to skip login page #5444
  • it automatically creates binary files for the OpenLens project and links these to the release page.
  • it provides a pre-compiled community FOSS alternative to the enterprise version that can be downloaded on https://k8slens.dev/
  • it supply a pull request to continue more productive discussions

limitations:

  • although build process for windows, ubuntu and mac succeeds, I was only able to verify the ubuntu version since I lack the necessary hardware. The low number of issues and problems reported with the repository of @MuhammedKalkan indicate that this is not a proplem.
  • I successfully tested functionality of the workflows in my repository on wip branch. But: I was not able to fully understand when the release-type event is called so that on release type: published is triggered. I just copied the trigger from the workflows existing in this repository.

@PhilippKuntschik PhilippKuntschik requested a review from a team as a code owner July 2, 2022 13:27
@PhilippKuntschik PhilippKuntschik requested review from jweak and aleksfront and removed request for a team July 2, 2022 13:27
Signed-off-by: Philipp Kuntschik <Philipp.Kuntschik@fhgr.ch>
@msa0311 msa0311 requested review from jakolehm, Nokel81 and msa0311 and removed request for jweak and aleksfront July 12, 2022 12:24
@msa0311 msa0311 added the discussion Initial discussions and proposals label Jul 12, 2022
@fabiocastagnino-horsa
Copy link

fabiocastagnino-horsa commented Nov 2, 2022

@jakolehm @Nokel81 @msa0311, why don't integrate the build artifacts in the repo? This PR solve this issue: #6075
There are already available in other repos like https://github.com/MuhammedKalkan/OpenLens

Thank you

@AndrewSav
Copy link

@fabiocastagnino-horsa because it would defeat the purpose of pushing the paid-for product with closed-source extensions. I think they figured out that if there are "official" releases without their bundled additions more people will use that instead of looking to pay for the subscription. Getting people on a "free" plan is getting a foot into the door, a possibility of conversion to a paying customer, supporting the open lens build achieves little for this goal. This means that this is low priority if any and no one is available to work on making it happen.

The sentiment is probably, that it is already out there and those who need/want it can build it themselves our use one of repos such as you linked, so it really is pointless to have them here. And if we learned something from the thread with the initial issue, it's that you are probably are not getting any response from Mirantis. They have been very terse in their communication with us.

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PhilippKuntschik PhilippKuntschik closed this by deleting the head repository Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Initial discussions and proposals PR: needs rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants