Fix bundled extensions not being loaded #7359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also show that this fixes it by added an example bundled extension to 'open-lens' Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
added
bug
Nokel81
requested review from
ixrock and
jim-docker
and removed request for
a team
Iku-turso
reviewed
Mar 15, 2023
There was a problem hiding this comment.
Would appreciate own commit for a "legacy-extension-example", maybe even a PR :)
Iku-turso
reviewed
Mar 15, 2023
| */ | ||
| import path from "path"; | ||
|
|
||
| const webpack = [ |
There was a problem hiding this comment.
Not ok to show duplicated webpack configuration in an example package :/
There was a problem hiding this comment.
This can be fixed in the future
Iku-turso
reviewed
Mar 15, 2023
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Iku-turso
reviewed
Mar 15, 2023
There was a problem hiding this comment.
Not completely sure, but this new package doesn't house any Features, and therefore shouldn't reside under technical-features.
There was a problem hiding this comment.
Needs to be said that a lot of what you just said hasn't been publicly discussed anywhere. 😞
There was a problem hiding this comment.
We also haven't had any discussions about why we are nesting the packages.
Iku-turso
approved these changes
Mar 15, 2023
Merged
gabriel-mirantis
pushed a commit
that referenced
this pull request
Mar 21, 2023
* Fix bundled extensions not being loaded - Also show that this fixes it by added an example bundled extension to 'open-lens' Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix build Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add explanatory comment for inline require Signed-off-by: Sebastian Malton <sebastian@malton.name> --------- Signed-off-by: Sebastian Malton <sebastian@malton.name> Signed-off-by: Gabriel <gaccettola@mirantis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7156
PROBLEM: bundled extensions are not registered either on
mainor onrendererSOLUTION: As proposed by @jansav, refactor the injection token into its own package and make it a
peerDependency