Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format 2: require numcodecs & use SHA256 #40

Merged
merged 26 commits into from
Dec 3, 2023

Conversation

mdekstrand
Copy link
Member

This creates Binpickle format 2, with the following changes:

  • Uses SHA256 digests instead of Adler32 checksums to verify integrity
  • Uses numcodecs for all codecs instead of our custom layer

Closes #34.

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (c5c7008) 95.47% compared to head (b2786bc) 93.93%.

Files Patch % Lines
binpickle/encode.py 87.87% 4 Missing ⚠️
binpickle/read.py 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   95.47%   93.93%   -1.54%     
==========================================
  Files          12        6       -6     
  Lines         486      330     -156     
==========================================
- Hits          464      310     -154     
+ Misses         22       20       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand marked this pull request as ready for review December 3, 2023 14:26
@mdekstrand mdekstrand merged commit 8ab8a1d into lenskit:main Dec 3, 2023
10 of 12 checks passed
@mdekstrand mdekstrand deleted the feature/v2 branch December 3, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove custom codec layer
1 participant