Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ALS and fix RR1 bug #231

Closed
wants to merge 1 commit into from

Conversation

mdekstrand
Copy link
Member

@mdekstrand mdekstrand commented Mar 6, 2021

This cleans up ALS a bit, and fixes a subtle bug in the coordinate descent implementation.

@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #231 (76e7778) into series/0.12 (9b481d6) will decrease coverage by 23.69%.
The diff coverage is 33.33%.

Impacted file tree graph

@@               Coverage Diff                @@
##           series/0.12     #231       +/-   ##
================================================
- Coverage        92.05%   68.36%   -23.70%     
================================================
  Files               43       43               
  Lines             3473     3464        -9     
================================================
- Hits              3197     2368      -829     
- Misses             276     1096      +820     
Impacted Files Coverage Δ
lenskit/algorithms/als.py 53.16% <33.33%> (-44.60%) ⬇️
lenskit/util/accum.py 22.22% <0.00%> (-77.78%) ⬇️
lenskit/algorithms/svd.py 30.15% <0.00%> (-65.08%) ⬇️
lenskit/algorithms/implicit.py 27.53% <0.00%> (-55.08%) ⬇️
lenskit/crossfold.py 46.28% <0.00%> (-52.90%) ⬇️
lenskit/util/array.py 50.00% <0.00%> (-50.00%) ⬇️
lenskit/util/test.py 41.66% <0.00%> (-45.84%) ⬇️
lenskit/util/data.py 53.33% <0.00%> (-40.01%) ⬇️
lenskit/math/solve.py 52.63% <0.00%> (-36.85%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b481d6...76e7778. Read the comment docs.

@mdekstrand mdekstrand closed this Mar 31, 2021
@mdekstrand mdekstrand deleted the fix/als-bug branch July 7, 2021 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant