Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use_ratings option to ImplicitMF #245

Merged
merged 2 commits into from
Apr 2, 2021

Conversation

mdekstrand
Copy link
Member

@mdekstrand mdekstrand commented Apr 2, 2021

This adds a use_ratings option to ImplicitMF, currently defaulting to True (previous behavior), but scheduled to start defaulting to False.

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #245 (c570422) into main (f9a6937) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   91.89%   92.13%   +0.24%     
==========================================
  Files          44       44              
  Lines        3565     3624      +59     
==========================================
+ Hits         3276     3339      +63     
+ Misses        289      285       -4     
Impacted Files Coverage Δ
lenskit/algorithms/als.py 98.05% <100.00%> (+0.06%) ⬆️
lenskit/util/__init__.py 84.48% <100.00%> (+0.84%) ⬆️
lenskit/crossfold.py 98.42% <0.00%> (-0.77%) ⬇️
lenskit/util/test.py 91.89% <0.00%> (+4.39%) ⬆️
lenskit/metrics/topn.py 100.00% <0.00%> (+4.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a6937...c570422. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Apr 2, 2021

Code Climate has analyzed commit c570422 and detected 0 issues on this pull request.

View more on Code Climate.

@mdekstrand mdekstrand added this to the 0.13.0 milestone Apr 2, 2021
@mdekstrand mdekstrand added the algorithms LensKit algorithm implementations label Apr 2, 2021
@mdekstrand mdekstrand merged commit 2c8e3db into lenskit:main Apr 2, 2021
@mdekstrand mdekstrand deleted the feature/imf-fix-col branch April 2, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithms LensKit algorithm implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant