This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Code signing for macOS #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😍 |
leo
previously requested changes
Aug 28, 2018
davej
dismissed
leo’s stale review
Oops, should have resolved this review differently. Anyway, changes made.
|
Thanks for review, changes made. |
leo
approved these changes
Sep 21, 2018
|
Thank you so much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an initial version to help start a discussion about how this should be done.
In particular, I'm a bit confused about the cross-over between
sign.entitlementsandinfoconfig properties.This closes #3.