Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Studio Integration #576

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

ManuelRauber
Copy link
Contributor

Hi @leoafarias

as per #310, this PR will improve fvm a bit around Android Studio.

  • Creates the flutter_sdk symlink again which was removed for 3-beta, but available in 2. After some research in [Feature Request] - Configure IDE path on "use" command #310 it seems that having flutter_sdk is the easiest way to work with dynamic SDKs in Android Studio, because Android Studio does not save one path to the SDK, but one path for each module. That seems to make trouble if fvm would start managing all those paths. So its best to leave it to Android Studio itself via the symlink.
  • Adds a little check to fvm doctor in order to check if Dart_SDK.xml contains $PROJECT_DIR (correct) or $USER_HOME$ (incorrect) and will also check, if it points to the flutter_sdk symlink.
  • In the docs, it looks like that you wanted to create dedicated pages for each IDE. So I've moved everything regarding Android Studio from configuration.mdx in a dedicated android_studio.md file.
  • I also added some more information in the docs

Please let me know, if there's anything else I can do in order to help with the Android Studio integration.

@kuhnroyal
Copy link
Contributor

This also works for the whole IntelliJ/Jetbrains suite so I would not make the documentation and CLI hints specific to Android Studio, just a thought.

@ManuelRauber
Copy link
Contributor Author

ManuelRauber commented Nov 30, 2023

This also works for the whole IntelliJ/Jetbrains suite so I would not make the documentation and CLI hints specific to Android Studio, just a thought.

Valid point.
Flutter also writes Android Studio, as well as IntelliJ.

So, I could rename it to "IntelliJ" or "IntelliJ (Android Studio, ...)" or something.

I'd like to include the term "Android Studio", because I think that beginners may have a hard time understanding, how JetBrains and the IDE landscape do work, so having similar wording could be helpful.

What do you think, @kuhnroyal?

@kuhnroyal
Copy link
Contributor

Sounds good!

@leoafarias
Copy link
Owner

Thank you @ManuelRauber, for this PR! will review it and bring it in before 3.0 release!

@leoafarias
Copy link
Owner

@ManuelRauber I ran locally and passed the tests, it seems the test failed because of dart format --fix was not run, but I will go ahead and bring it over

@leoafarias leoafarias merged commit 12389c5 into leoafarias:main Jan 4, 2024
0 of 3 checks passed
@ManuelRauber ManuelRauber deleted the feature/intellij branch January 8, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants