Add support for CRLF when parsing RSA PEM keys #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/src/algorithms/rsa.dart
Outdated
| @@ -64,8 +64,7 @@ class RSAKeyParser { | |||
| return _parsePrivate(_pkcs8PrivateSequence(_parseSequence(rows))); | |||
| } | |||
|
|
|||
| // NOTE: Should we throw an exception? | |||
| return null; | |||
| throw ArgumentError('Unable to parse key, invalid format.'); | |||
There was a problem hiding this comment.
I left this note for further discussion.
Why do you think we should throw an exception?
There was a problem hiding this comment.
Because the methods taking the parsed key as an argument will most likely throw an exception if the key is null. Fail-fast would be better in this case.
There was a problem hiding this comment.
Do you agree that a FormatException is better is this case?
There was a problem hiding this comment.
Yes, absolutely. Will fix it right away.
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36