Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer AutoShow #128

Merged
merged 3 commits into from
May 7, 2021
Merged

Drawer AutoShow #128

merged 3 commits into from
May 7, 2021

Conversation

orapps44
Copy link
Collaborator

Purpose of this request is to add Auto Show drawer feature when mouse over drawer (usefull when DrawerShowIconsWhenHidden = true) .

Attached code almost works but one bug remains and I wasn't able to solve it yet.

Right after application start, I can see drawer opening once mouse over but then animation seems to be stuck with everything disabled. But once a click event is done (everywhere in form) then all works fine.

Does anyone could help ?

Copy link
Owner

@leocb leocb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing your work!
This is related to #124
Just fix the bug you mentioned and I'll merge this.
I'll take a look too, this is probably just some winform initialization nonsense

MaterialSkin/Controls/MaterialDrawer.cs Show resolved Hide resolved
@leocb leocb mentioned this pull request Jan 19, 2021
@leocb leocb merged commit c510aa8 into leocb:master May 7, 2021
@ghost
Copy link

ghost commented May 8, 2021

In AddDrawerOverlayForm form MarerialForm, I moved Overlay Form definitions over Drawer Form definitions and AutoShowDrawer works fine, no bug

@orapps44
Copy link
Collaborator Author

orapps44 commented May 8, 2021

Thanks @gabigtr5 for your comment.
I would appreciate if you could share your modifications and/or create a PR.

orapps44 added a commit that referenced this pull request May 9, 2021
@orapps44 orapps44 added this to the 2.2 milestone May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants