Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MaterialTextBox2 Text overlapping Hint #292

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Fix MaterialTextBox2 Text overlapping Hint #292

merged 2 commits into from
Nov 11, 2021

Conversation

valimaties
Copy link

Fix baseTextBox position when initial text is set.

@valimaties valimaties mentioned this pull request Nov 10, 2021
Closed
@valimaties valimaties changed the title Fix MaterialTextBox Text overlapping Hint Fix MaterialTextBox2 Text overlapping Hint Nov 10, 2021
orapps44
orapps44 reviewed Nov 11, 2021
View reviewed changes
Copy link
Collaborator

@orapps44 orapps44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks correct. But I don't think Invalidate(); is necessary (allready managed by baseTextBox.TextChanged += new EventHandler(Redraw); ).

@valimaties
Copy link
Author

Removed Invalidate.

@orapps44 orapps44 merged commit c718291 into leocb:master Nov 11, 2021
@valimaties valimaties deleted the FixBaseTextBoxLocation branch November 11, 2021 12:02
@orapps44 orapps44 linked an issue Nov 11, 2021 that may be closed by this pull request
Toggling MaterialTextBox2's Enabled Property Doesn't Propagate to the Inner Control #289
Closed
@orapps44 orapps44 added this to the 2.3.1 milestone Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orapps44 orapps44 orapps44 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

Toggling MaterialTextBox2's Enabled Property Doesn't Propagate to the Inner Control
2 participants
@valimaties @orapps44