fix authentication cloudflare issue #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bs4 was only used to parse an html page to get a CSRF token for authentication, which can be replaced with simpler splits
Removed typing's `Optional` from some function's arguments since it was clearly an optional with a default value, and also caused PyRight to scream as you cannot call members of an Optional[Any] the same as Any.
As Pyright cannot know which type is returned from `get_orders`, overloading it with distinct return types fixes the issue
Loading homepage sometimes lands on cloudflare making authentication fail. Switching to header authentication. renaming `get_csrf_and_jwt` to `get_jwt_token`
leonardodalinky
approved these changes
Oct 15, 2023
|
The formatter check fails... Could you check |
format using `make black` and `make isort` commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading homepage may sometimes land on cloudflare making getting the csrf token impossible. This workaround uses header authentication instead of cookies.
Added support for item subtypes for Order types.
Also refactored code (see commits)